- Mar 10, 2014
-
-
Chandler Carruth authored
lines under 80-columns, etc. llvm-svn: 203434
-
Craig Topper authored
llvm-svn: 203433
-
Chandler Carruth authored
clang-format, but with some modifications by me where it got things wrong or got confused. llvm-svn: 203432
-
Chandler Carruth authored
constructors from the classes which only have a single reference member to many other places. This resulted in them copying their single member instead of moving. =/ Fix this. There's really not a useful test to add sadly because these move constructors are only called when something deep inside some standard library implementation *needs* to move them. Many of the types aren't even user-impacting types. Or, the objects are copyable anyways and so the result was merely a performance problem rather than a correctness problem. Anyways, thanks for the review. And this is a great example of why I wish I colud have the compiler write these for me. llvm-svn: 203431
-
David Majnemer authored
This is fallout from r203429. llvm-svn: 203430
-
David Majnemer authored
Split by comma once instead of multiple times. Moving this upfront makes the rest of the code considerably simpler. No functional change. llvm-svn: 203429
-
Chandler Carruth authored
class that might (at some point) need them. llvm-svn: 203428
-
Chandler Carruth authored
members as being te workaround MSVC. llvm-svn: 203427
-
Chandler Carruth authored
synthesize a move constructor. Thus, for any types where move semantics are important (yea, that's essentially every type...) you must explicitly define the special members. Do so systematically throughout the pass manager as the core of the design relies heavily on move semantics. This will hopefully fix the build with MSVC 2013. We still don't know why MSVC 2012 accepted this code, but it almost certainly wasn't doing the right thing. I've also added explicit to a few single-argument constructors spotted in passing. llvm-svn: 203426
-
Venkatraman Govindaraju authored
llvm-svn: 203424
-
Bob Wilson authored
llvm-svn: 203423
-
- Mar 09, 2014
-
-
Ed Maste authored
FreeBSD's rtld requires the DF_ORIGIN flag set in order to process $ORIGIN in rpath. FreeBSD bug http://bugs.freebsd.org/187114 llvm-svn: 203419
-
Craig Topper authored
llvm-svn: 203418
-
Benjamin Kramer authored
No functionality change. llvm-svn: 203415
-
Benjamin Kramer authored
llvm-svn: 203414
-
Benjamin Kramer authored
No change in functionality. llvm-svn: 203413
-
Chandler Carruth authored
Still more work to be done here to leverage C++11, but this clears out the glaring issues. llvm-svn: 203395
-
Chandler Carruth authored
llvm-svn: 203394
-
Ahmed Charles authored
llvm-svn: 203393
-
Chandler Carruth authored
horrible smart pointer by std::unique_ptr and strict move semantics, rip this out. llvm-svn: 203392
-
Chandler Carruth authored
it is available. Also make the move semantics sufficiently correct to tolerate move-only passes, as the PassManagers *are* move-only passes. llvm-svn: 203391
-
Ahmed Charles authored
llvm-svn: 203387
-
NAKAMURA Takumi authored
It choked i686 stage2. llvm-svn: 203386
-
Craig Topper authored
llvm-svn: 203379
-
Craig Topper authored
llvm-svn: 203378
-
David Majnemer authored
The grammar for LLVM IR is not well specified in any document but seems to obey the following rules: - Attributes which have parenthesized arguments are never preceded by commas. This form of attribute is the only one which ever has optional arguments. However, not all of these attributes support optional arguments: 'thread_local' supports an optional argument but 'addrspace' does not. Interestingly, 'addrspace' is documented as being a "qualifier". What constitutes a qualifier? I cannot find a definition. - Some attributes use a space between the keyword and the value. Examples of this form are 'align' and 'section'. These are always preceded by a comma. - Otherwise, the attribute has no argument. These attributes do not have a preceding comma. Sometimes an attribute goes before the instruction, between the instruction and it's type, or after it's type. 'atomicrmw' has 'volatile' between the instruction and the type while 'call' has 'tail' preceding the instruction. With all this in mind, it seems most consistent for 'inalloca' on an 'inalloca' instruction to occur before between the instruction and the type. Unlike the current formulation, there would be no preceding comma. The combination 'alloca inalloca' doesn't look particularly appetizing, perhaps a better spelling of 'inalloca' is down the road. llvm-svn: 203376
-
David Blaikie authored
This reverts commit r203374. Ambiguities in assign... oh well. I'm just going to revert this and probably not try to recommit it as it's not terribly important. llvm-svn: 203375
-
David Blaikie authored
Move a common utility (assign(iter, iter)) into SmallVector (some of the others could be moved there too, but this one seemed particularly generic) and replace repetitions overrides with using directives. And simplify SmallVector::assign(num, element) while I'm here rather than thrashing these files (that cause everyone to rebuild) again. llvm-svn: 203374
-
Ahmed Charles authored
MSVC (2012, 2013, 2013 Nov CTP) fail on the following code: int main() { int arr[] = {1, 2}; for (int i : arr) do {} while (0); } The fix is to put {} around the for loop. I've reported this to the MSVC team. llvm-svn: 203371
-
Ahmed Charles authored
llvm-svn: 203366
-
Chandler Carruth authored
This requires a number of steps. 1) Move value_use_iterator into the Value class as an implementation detail 2) Change it to actually be a *Use* iterator rather than a *User* iterator. 3) Add an adaptor which is a User iterator that always looks through the Use to the User. 4) Wrap these in Value::use_iterator and Value::user_iterator typedefs. 5) Add the range adaptors as Value::uses() and Value::users(). 6) Update *all* of the callers to correctly distinguish between whether they wanted a use_iterator (and to explicitly dig out the User when needed), or a user_iterator which makes the Use itself totally opaque. Because #6 requires churning essentially everything that walked the Use-Def chains, I went ahead and added all of the range adaptors and switched them to range-based loops where appropriate. Also because the renaming requires at least churning every line of code, it didn't make any sense to split these up into multiple commits -- all of which would touch all of the same lies of code. The result is still not quite optimal. The Value::use_iterator is a nice regular iterator, but Value::user_iterator is an iterator over User*s rather than over the User objects themselves. As a consequence, it fits a bit awkwardly into the range-based world and it has the weird extra-dereferencing 'operator->' that so many of our iterators have. I think this could be fixed by providing something which transforms a range of T&s into a range of T*s, but that *can* be separated into another patch, and it isn't yet 100% clear whether this is the right move. However, this change gets us most of the benefit and cleans up a substantial amount of code around Use and User. =] llvm-svn: 203364
-
- Mar 08, 2014
-
-
Adam Nemet authored
llvm-svn: 203361
-
Aaron Ballman authored
llvm-svn: 203356
-
Aaron Ballman authored
Adding range-based STL-like helper APIs. llvm::distance() is the range version of std::distance. llvm::copy is the range version of std::copy. llvm-svn: 203354
-
Lang Hames authored
relevant subclasses of RuntimeDyldImpl. This allows construction of RuntimeDyldImpl instances to be deferred until after the target architecture is known. llvm-svn: 203352
-
Duncan P. N. Exon Smith authored
llvm-svn: 203347
-
Ahmed Charles authored
llvm-svn: 203346
-
Craig Topper authored
llvm-svn: 203345
-
Craig Topper authored
llvm-svn: 203344
-
Adam Nemet authored
Args is an output parameter of the function lexCommand but the reference operator was missed. llvm-svn: 203343
-