- Nov 01, 2012
-
-
Chandler Carruth authored
r165941: Resubmit the changes to llvm core to update the functions to support different pointer sizes on a per address space basis. Despite this commit log, this change primarily changed stuff outside of VMCore, and those changes do not carry any tests for correctness (or even plausibility), and we have consistently found questionable or flat out incorrect cases in these changes. Most of them are probably correct, but we need to devise a system that makes it more clear when we have handled the address space concerns correctly, and ideally each pass that gets updated would receive an accompanying test case that exercises that pass specificaly w.r.t. alternate address spaces. However, from this commit, I have retained the new C API entry points. Those were an orthogonal change that probably should have been split apart, but they seem entirely good. In several places the changes were very obvious cleanups with no actual multiple address space code added; these I have not reverted when I spotted them. In a few other places there were merge conflicts due to a cleaner solution being implemented later, often not using address spaces at all. In those cases, I've preserved the new code which isn't address space dependent. This is part of my ongoing effort to clean out the partial address space code which carries high risk and low test coverage, and not likely to be finished before the 3.2 release looms closer. Duncan and I would both like to see the above issues addressed before we return to these changes. llvm-svn: 167222
-
Chandler Carruth authored
getIntPtrType support for multiple address spaces via a pointer type, and also introduced a crasher bug in the constant folder reported in PR14233. These commits also contained several problems that should really be addressed before they are re-committed. I have avoided reverting various cleanups to the DataLayout APIs that are reasonable to have moving forward in order to reduce the amount of churn, and minimize the number of commits that were reverted. I've also manually updated merge conflicts and manually arranged for the getIntPtrType function to stay in DataLayout and to be defined in a plausible way after this revert. Thanks to Duncan for working through this exact strategy with me, and Nick Lewycky for tracking down the really annoying crasher this triggered. (Test case to follow in its own commit.) After discussing with Duncan extensively, and based on a note from Micah, I'm going to continue to back out some more of the more problematic patches in this series in order to ensure we go into the LLVM 3.2 branch with a reasonable story here. I'll send a note to llvmdev explaining what's going on and why. Summary of reverted revisions: r166634: Fix a compiler warning with an unused variable. r166607: Add some cleanup to the DataLayout changes requested by Chandler. r166596: Revert "Back out r166591, not sure why this made it through since I cancelled the command. Bleh, sorry about this! r166591: Delete a directory that wasn't supposed to be checked in yet. r166578: Add in support for getIntPtrType to get the pointer type based on the address space. llvm-svn: 167221
-
Owen Anderson authored
llvm-svn: 167200
-
Jakob Stoklund Olesen authored
The static compose() function in RegisterCoalescer was doing the exact same thing. llvm-svn: 167198
-
- Oct 31, 2012
-
-
Benjamin Kramer authored
No functionality change. llvm-svn: 167116
-
Akira Hatanaka authored
type MachineInstr* and MachineBasicBlock::iterator. llvm-svn: 167088
-
Akira Hatanaka authored
llvm-svn: 167086
-
- Oct 30, 2012
-
-
Chad Rosier authored
llvm-svn: 167050
-
Chad Rosier authored
llvm-svn: 167046
-
Chad Rosier authored
the MachineInstr MayLoad/MayLoad flags are based on the tablegen implementation. For inline assembly, however, we need to compute these based on the constraints. Revert r166929 as this is no longer needed, but leave the test case in place. rdar://12033048 and PR13504 llvm-svn: 167040
-
Bill Wendling authored
llvm-svn: 167029
-
- Oct 29, 2012
-
-
Ulrich Weigand authored
checks to avoid performing compile-time arithmetic on PPCDoubleDouble. Now that APFloat supports arithmetic on PPCDoubleDouble, those checks are no longer needed, and we can treat the type like any other. llvm-svn: 166958
-
Jakob Stoklund Olesen authored
Partial copies can show up even when CoalescerPair.isPartial() returns false. For example: %vreg24:dsub_0<def> = COPY %vreg31:dsub_0; QPR:%vreg24,%vreg31 Such a partial-partial copy is not good enough for the transformation adjustCopiesBackFrom() needs to do. llvm-svn: 166944
-
Duncan Sands authored
wrapper returns a vector of integers when passed a vector of pointers) by having getIntPtrType itself return a vector of integers in this case. Outside of this wrapper, I didn't find anywhere in the codebase that was relying on the old behaviour for vectors of pointers, so give this a whirl through the buildbots. llvm-svn: 166939
-
Preston Gurd authored
incorrect instruction sequence due to it not being aware that an inline assembly instruction may reference memory. This patch fixes the problem by causing the scheduler to always assume that any inline assembly code instruction could access memory. This is necessary because the internal representation of the inline instruction does not include any information about memory accesses. This should fix PR13504. llvm-svn: 166929
-
Lang Hames authored
llvm-svn: 166910
-
- Oct 27, 2012
-
-
Jakob Stoklund Olesen authored
This fixes PR14194. llvm-svn: 166880
-
Jakob Stoklund Olesen authored
No functional change. llvm-svn: 166829
-
Jakob Stoklund Olesen authored
Don't pass it around everywhere as a function argument. llvm-svn: 166828
-
Jakob Stoklund Olesen authored
Don't pass it everywhere as an argument. llvm-svn: 166820
-
- Oct 26, 2012
-
-
Jakob Stoklund Olesen authored
No functional change. llvm-svn: 166814
-
Jakob Stoklund Olesen authored
The new coalescer can already do all of this, so there is no need to duplicate the efforts. llvm-svn: 166813
-
Akira Hatanaka authored
llvm-svn: 166784
-
Nicolas Geoffray authored
llvm-svn: 166763
-
Nick Lewycky authored
llvm-svn: 166750
-
- Oct 25, 2012
-
-
Jakob Stoklund Olesen authored
llvm-svn: 166646
-
- Oct 24, 2012
-
-
Micah Villmow authored
llvm-svn: 166607
-
Micah Villmow authored
Back out r166591, not sure why this made it through since I cancelled the command. Bleh, sorry about this! llvm-svn: 166596
-
Micah Villmow authored
llvm-svn: 166591
-
Micah Villmow authored
This checkin also adds in some tests that utilize these paths and updates some of the clients. llvm-svn: 166578
-
Michael Liao authored
- If more than 1 elemennts are defined and target supports the vectorized conversion, use the vectorized one instead to reduce the strength on conversion operation. llvm-svn: 166546
-
Jakub Staszak authored
llvm-svn: 166531
-
Michael Liao authored
llvm-svn: 166519
-
- Oct 23, 2012
-
-
Nadav Rotem authored
Make the indirect branch optimization deterministic. No functionality change. Patch by Daniel Reynaud. llvm-svn: 166501
-
Richard Smith authored
every TU where it's implicitly instantiated, even if there's an implicit instantiation for the same types available in another TU. llvm-svn: 166470
-
- Oct 21, 2012
-
-
Jakob Stoklund Olesen authored
Reported by Vincent Lejeune using an out-of-tree target. llvm-svn: 166398
-
- Oct 20, 2012
-
-
Benjamin Kramer authored
llvm-svn: 166376
-
Shuxin Yang authored
(The change at Clang side was committed in r166345) 2. Cosmetic change in order to conform to coding standards. llvm-svn: 166350
-
- Oct 19, 2012
-
-
Nadav Rotem authored
llvm-svn: 166340
-
radar://8426430Shuxin Yang authored
which is supposed to consistently raise SIGTRAP across all systems. In contrast, __builtin_trap() behave differently on different systems. e.g. it raises SIGTRAP on ARM, and SIGILL on X86. The purpose of __builtin_debugtrap() is to consistently provide "trap" functionality, in the mean time preserve the compatibility with on gcc on __builtin_trap(). The X86 backend is already able to handle debugtrap(). This patch is to: 1) make front-end recognize "__builtin_debugtrap()" (emboddied in the one-line change to Clang). 2) In DAG legalization phase, by default, "debugtrap" will be replaced with "trap", which make the __builtin_debugtrap() "available" to all existing ports without the hassle of changing their code. 3) If trap-function is specified (via -trap-func=xyz to llc), both __builtin_debugtrap() and __builtin_trap() will be expanded into the function call of the specified trap function. This behavior may need change in the future. The provided testing-case is to make sure 2) and 3) are working for ARM port, and we already have a testing case for x86. llvm-svn: 166300
-