Refactored Builtin::Context::isPrintfLike and isScanfLike into a helper function. The implementations are identical, except for the format arguments being searched for.

No functional changes intended.

llvm-svn: 198446

llvm-svn: 198444

llvm-svn: 198442

Fixing a FIXME; the RetTy template parameter is always bool in practice, and so it has been removed. No functional changes intended.

llvm-svn: 198440

llvm-svn: 198439

llvm-svn: 198435

Removed one of the string versions of getQualifiedNameAsString, and switched over to using printQualifiedName where possible. No functional changes intended.

llvm-svn: 198433

- Remove the additions to ObjCMethodDecl & ObjCIVarDecl that were getting de/serialized and consolidate
  all functionality for the checking for this warning in Sema::DiagnoseUnusedBackingIvarInAccessor
- Don't check immediately after the method body is finished, check when the @implementation is finished.
  This is so we can see if the ivar was referenced by any other method, even if the method was defined after the accessor.
- Don't silence the warning if any method is called from the accessor silence it if the accessor delegates to another method via self.

rdar://15727325

llvm-svn: 198432

llvm-svn: 198430

llvm-svn: 198429

Fixed a FIXME; created a print method for Selectors that accepts a raw_ostream, and started using it in places it made sense.

No functional changes intended, just API cleanliness.

llvm-svn: 198428

Summary:
This allows for a better alternative to the FrontendAction hack used in
clang-tidy in order to get static analyzer's ASTConsumer.

Reviewers: jordan_rose, krememek

Reviewed By: jordan_rose

CC: cfe-commits

Differential Revision: http://llvm-reviews.chandlerc.com/D2505

llvm-svn: 198426

Simplifying the mutual exclusion check now that the diagnostics engine knows how to handle Attr objects directly. Updates an associated test case due to the attribute name being properly quoted again.

llvm-svn: 198424

llvm-svn: 198422

Using the proper helper function instead of manually doing this work. No functional changes intended.

llvm-svn: 198421

llvm-svn: 198420

llvm-svn: 198419

llvm-svn: 198418

llvm-svn: 198417

llvm-svn: 198416

It turns out the problem was a bit more wide-spread. Removing a lot of unneeded typecasts. getScopeRep() already returns a NestedNameSpecifier.

No functional changes intended.

llvm-svn: 198414

llvm-svn: 198413

Removing some more unnecessary manual quotes from diagnostics. Updated the related test case to ensure correctness.

llvm-svn: 198412

Before:
  #define LIST(L)                                                     \
    L(FirstElement) L(SecondElement) L(ThirdElement) L(FourthElement) \
        L(FifthElement)

After:
  #define LIST(L)    \
    L(FirstElement)  \
    L(SecondElement) \
    L(ThirdElement)  \
    L(FourthElement) \
    L(FifthElement)

llvm-svn: 198407

llvm-svn: 198395

llvm-svn: 198392

llvm-svn: 198391

Fixes <rdar://problem/12858915>.

llvm-svn: 198388

llvm-svn: 198387

llvm-svn: 198382

Summary:
No functionality change.

This code should live here long-term because we should be able to use it
to compute correct vftable names.

It turns out that the most natural way to implement the naming algorithm
is to use a caching layer similar to what we already have for virtual
table info in VTableContext.  Subsequent changes will take advantage of
this to fix PR17748, where we have a vbtable name collision.

Reviewers: majnemer

CC: cfe-commits

Differential Revision: http://llvm-reviews.chandlerc.com/D2499

llvm-svn: 198380

Removed an unnecessary %select from the alignas diagnostics. The attribute already knows how it was spelled.

llvm-svn: 198375

This diagnostic should not have had the manual quotation marks. Its only usage passed in an Attr object, which was already quoted when printing the diagnostic. However, there was no test case that caught this bug -- one has been added.

llvm-svn: 198373

Removing some more unnecessary manual quotes from attribute diagnostics. Updated the associated testcase because QualType pretty printing was an improvement.

llvm-svn: 198372

llvm-svn: 198371

Reworded the NSObject attribute diagnostics to be more consistent with other attribute diagnostics. Also updated the associated test case.

llvm-svn: 198368

backing ivar by not issuing this warning if ivar is referenced
somewhere and accessor makes method calls. // rdar://15727325

llvm-svn: 198367

Removing some manual quotes from this diagnostic, since the AST diagnostics engine knows how to handle NamedDecl objects.

llvm-svn: 198365

Updated the wording of two attribute-related diagnostics so that they print the offending attribute name. Also updates the associated test cases.

llvm-svn: 198355

Fixes <rdar://problem/15713945>.

llvm-svn: 198343