Skip to content
  1. Oct 08, 2013
  2. Oct 07, 2013
  3. Oct 06, 2013
    • David Majnemer's avatar
      Revert "Windows: Add support for unicode command lines" · f636cf42
      David Majnemer authored
      This is causing MinGW bots to fail.
      This reverts commit r192069.
      
      llvm-svn: 192070
      f636cf42
    • David Majnemer's avatar
      Windows: Add support for unicode command lines · 80bea0c3
      David Majnemer authored
      Summary:
      The MSVCRT deliberately sends main() code-page specific characters.
      This isn't too useful to LLVM as we end up converting the arguments to
      UTF-16 and subsequently attempt to use the result as, for example, a
      file name.  Instead, we need to have the ability to access the Unicode
      command line and transform it to UTF-8.
      
      This has the distinct advantage over using the MSVC-specific wmain()
      function as our entry point because:
       - It doesn't work on cygwin.
       - It only work on MinGW with caveats and only then on certain versions.
       - We get to keep our entry point as main(). :)
      
      N.B.  This patch includes fixes to other parts of lib/Support/Windows
      s.t. we would be able to take advantage of getting the Unicode paths.
      E.G.  clang spawning clang -cc1 would want to give it Unicode arguments.
      
      Reviewers: aaron.ballman, Bigcheese, rnk, ruiu
      
      Reviewed By: rnk
      
      CC: llvm-commits, ygao
      
      Differential Revision: http://llvm-reviews.chandlerc.com/D1834
      
      llvm-svn: 192069
      80bea0c3
Loading