Skip to content
  1. Jul 11, 2013
    • Hal Finkel's avatar
      RegScavenger should not exclude undef uses · 743b1940
      Hal Finkel authored
      When computing currently-live registers, the register scavenger excludes undef
      uses. As a result, undef uses are ignored when computing the restore points of
      registers spilled into the emergency slots. While the register scavenger
      normally excludes from consideration, when scavenging, registers used by the
      current instruction, we need to not exclude undef uses. Otherwise, we might end
      up requiring more emergency spill slots than we have (in the case where the
      undef use *is* the currently-spilled register).
      
      Another bug found by llvm-stress.
      
      llvm-svn: 186067
      743b1940
    • Craig Topper's avatar
      Fix indentation. No functional change. · 37039640
      Craig Topper authored
      llvm-svn: 186065
      37039640
    • Nadav Rotem's avatar
      Fix a warning. · 08efb262
      Nadav Rotem authored
      llvm-svn: 186064
      08efb262
    • Nadav Rotem's avatar
      Consolidate more lit tests. · 108ef760
      Nadav Rotem authored
      llvm-svn: 186063
      108ef760
    • Nadav Rotem's avatar
      Consolidate some of the lit tests. · e0a49499
      Nadav Rotem authored
      llvm-svn: 186062
      e0a49499
    • Nadav Rotem's avatar
      Consolidate some of the lit tests. · c6b5e249
      Nadav Rotem authored
      llvm-svn: 186060
      c6b5e249
    • Nadav Rotem's avatar
      SLPVectorizer: refactor the code that places extracts. Place the code that... · b8dd66f6
      Nadav Rotem authored
      SLPVectorizer: refactor the code that places extracts. Place the code that decides where to put extracts in the build-tree phase. This allows us to take the cost of the extracts into account.
      
      llvm-svn: 186058
      b8dd66f6
    • Michael Gottesman's avatar
      Teach TailRecursionElimination to handle certain cases of nocapture escaping allocas. · b40db26e
      Michael Gottesman authored
      Without the changes introduced into this patch, if TRE saw any allocas at all,
      TRE would not perform TRE *or* mark callsites with the tail marker.
      
      Because TRE runs after mem2reg, this inadequacy is not a death sentence. But
      given a callsite A without escaping alloca argument, A may not be able to have
      the tail marker placed on it due to a separate callsite B having a write-back
      parameter passed in via an argument with the nocapture attribute.
      
      Assume that B is the only other callsite besides A and B only has nocapture
      escaping alloca arguments (*NOTE* B may have other arguments that are not passed
      allocas). In this case not marking A with the tail marker is unnecessarily
      conservative since:
      
        1. By assumption A has no escaping alloca arguments itself so it can not
           access the caller's stack via its arguments.
      
        2. Since all of B's escaping alloca arguments are passed as parameters with
           the nocapture attribute, we know that B does not stash said escaping
           allocas in a manner that outlives B itself and thus could be accessed
           indirectly by A.
      
      With the changes introduced by this patch:
      
        1. If we see any escaping allocas passed as a capturing argument, we do
           nothing and bail early.
      
        2. If we do not see any escaping allocas passed as captured arguments but we
           do see escaping allocas passed as nocapture arguments:
      
             i. We do not perform TRE to avoid PR962 since the code generator produces
                significantly worse code for the dynamic allocas that would be created
                by the TRE algorithm.
      
             ii. If we do not return twice, mark call sites without escaping allocas
                 with the tail marker. *NOTE* This excludes functions with escaping
                 nocapture allocas.
      
        3. If we do not see any escaping allocas at all (whether captured or not):
      
             i. If we do not have usage of setjmp, mark all callsites with the tail
                marker.
      
             ii. If there are no dynamic/variable sized allocas in the function,
                 attempt to perform TRE on all callsites in the function.
      
      Based off of a patch by Nick Lewycky.
      
      rdar://14324281.
      
      llvm-svn: 186057
      b40db26e
    • Hal Finkel's avatar
      Move r186044 tests into CodeGen/X86 · 94383e54
      Hal Finkel authored
      I had thought that these tests could be target-neutral, but in practice this is
      not the case (on some targets, like Hexagon and Darwin), they trigger an assert
      (a different assert than the one that r186044 fixes).
      
      llvm-svn: 186051
      94383e54
    • Hal Finkel's avatar
      Set REQUIRES shell on the test cases for r186044 · a2aeb8e8
      Hal Finkel authored
      Trying to fix the i686-mingw32 build.
      
      llvm-svn: 186046
      a2aeb8e8
    • Hal Finkel's avatar
      XFAIL the test cases for r186044 on Hexagon · 31ffcec9
      Hal Finkel authored
      For some reason, the Hexagon backend does not reject these invalid static
      initializer expressions, but instead crashes in AsmPrinter::EmitGlobalConstant.
      
      llvm-svn: 186045
      31ffcec9
    • Hal Finkel's avatar
      Don't assert if we can't constant fold extract/insertvalue · b31366da
      Hal Finkel authored
      A non-constant-foldable static initializer expression containing insertvalue or
      extractvalue had been causing an assert:
      
        Constants.cpp:1971: Assertion `FC && "ExtractValue constant expr couldn't be
                                       folded!"' failed.
      
      Now we report a more-sensible "Unsupported expression in static initializer"
      error instead.
      
      Fixes PR15417.
      
      llvm-svn: 186044
      b31366da
    • Rafael Espindola's avatar
      Remove this test for now. · 555aa899
      Rafael Espindola authored
      It is not reliable to depend on the output of llvm_unreachable. The original
      change will have proper tests when llvm-ar moves to lib/Object (soon).
      
      llvm-svn: 186043
      555aa899
    • Hans Wennborg's avatar
      CommandLine.rst: remove tiny bit of bad mark-up · 0c14cf9a
      Hans Wennborg authored
      llvm-svn: 186042
      0c14cf9a
    • Rafael Espindola's avatar
      Find the symbol table on archives created on OS X. · 55509920
      Rafael Espindola authored
      llvm-svn: 186041
      55509920
  2. Jul 10, 2013
Loading