Skip to content
  1. Oct 01, 2012
    • Chandler Carruth's avatar
      Fix more misspellings found by Duncan during review. · 9866b97f
      Chandler Carruth authored
      llvm-svn: 164940
      9866b97f
    • Chandler Carruth's avatar
      Fix several issues with alignment. We weren't always accounting for type · 176ca71a
      Chandler Carruth authored
      alignment requirements of the new alloca. As one consequence which was
      reported as a bug by Duncan, we overaligned memcpy calls to ranges of
      allocas after they were rewritten to types with lower alignment
      requirements. Other consquences are possible, but I don't have any test
      cases for them.
      
      llvm-svn: 164937
      176ca71a
    • Benjamin Kramer's avatar
      SimplifyCFG: Don't crash when forming a switch bitmap with an undef default value. · 9fc3dc77
      Benjamin Kramer authored
      Fixes PR13985.
      
      llvm-svn: 164934
      9fc3dc77
    • Chandler Carruth's avatar
      Refactor the PartitionUse structure to actually use the Use* instead of · 54e8f0b4
      Chandler Carruth authored
      a pair of instructions, one for the used pointer and the second for the
      user. This simplifies the representation and also makes it more dense.
      
      This was noticed because of the miscompile in PR13926. In that case, we
      were running up against a fundamental "bad idea" in the speculation of
      PHI and select instructions: the speculation and rewriting are
      interleaved, which requires phi speculation to also perform load
      rewriting! This is bad, and causes us to miss opportunities to do (for
      example) vector rewriting only exposed after PHI speculation, etc etc.
      It also, in the old system, required us to insert *new* load uses into
      the current partition's use list, which would then be ignored during
      rewriting because we had already extracted an end iterator for the use
      list. The appending behavior (and much of the other oddities) stem from
      the strange de-duplication strategy in the PartitionUse builder.
      Amusingly, all this went without notice for so long because it could
      only be triggered by having *different* GEPs into the same partition of
      the same alloca, where both different GEPs were operands of a single
      PHI, and where the GEP which was not encountered first also had multiple
      uses within that same PHI node... Hence the insane steps required to
      reproduce.
      
      So, step one in fixing this fundamental bad idea is to make the
      PartitionUse actually contain a Use*, and to make the builder do proper
      deduplication instead of funky de-duplication. This is enough to remove
      the appending behavior, and fix the miscompile in PR13926, but there is
      more work to be done here. Subsequent commits will lift the speculation
      into its own visitor. It'll be a useful step toward potentially
      extracting all of the speculation logic into a generic utility
      transform.
      
      The existing PHI test case for repeated operands has been made more
      extreme to catch even these issues. This test case, run through the old
      pass, will exactly reproduce the miscompile from PR13926. ;] We were so
      close here!
      
      llvm-svn: 164925
      54e8f0b4
  2. Sep 30, 2012
  3. Sep 29, 2012
    • Bob Wilson's avatar
      Add LLVM support for Swift. · e8a549cd
      Bob Wilson authored
      llvm-svn: 164899
      e8a549cd
    • Bob Wilson's avatar
      Whitespace. · 63605ef3
      Bob Wilson authored
      llvm-svn: 164898
      63605ef3
    • Chandler Carruth's avatar
      Fix a somewhat surprising miscompile where code relying on an ABI · 903790ef
      Chandler Carruth authored
      alignment could lose it due to the alloca type moving down to a much
      smaller alignment guarantee.
      
      Now SROA will actively compute a proper alignment, factoring the target
      data, any explicit alignment, and the offset within the struct. This
      will in some cases lower the alignment requirements, but when we lower
      them below those of the type, we drop the alignment entirely to give
      freedom to the code generator to align it however is convenient.
      
      Thanks to Duncan for the lovely test case that pinned this down. =]
      
      llvm-svn: 164891
      903790ef
    • Duncan Sands's avatar
      Speculatively revert commit 164885 (nadav) in the hope of ressurecting a pile of · fb9d30dd
      Duncan Sands authored
      buildbots.  Original commit message:
      
      A DAGCombine optimization for merging consecutive stores. This optimization is not profitable in many cases
      because moden processos can store multiple values in parallel, and preparing the consecutive store requires
      some work.  We only handle these cases:
      
      1. Consecutive stores where the values and consecutive loads. For example:
        int a = p->a;
        int b = p->b;
        q->a = a;
        q->b = b;
      
      2. Consecutive stores where the values are constants. Foe example:
        q->a = 4;
        q->b = 5;
      
      llvm-svn: 164890
      fb9d30dd
    • Nadav Rotem's avatar
      · a2e7ea2f
      Nadav Rotem authored
      A DAGCombine optimization for merging consecutive stores. This optimization is not profitable in many cases
      because moden processos can store multiple values in parallel, and preparing the consecutive store requires
      some work.  We only handle these cases:
      
      1. Consecutive stores where the values and consecutive loads. For example:
        int a = p->a;
        int b = p->b;
        q->a = a;
        q->b = b;
      
      2. Consecutive stores where the values are constants. Foe example:
        q->a = 4;
        q->b = 5;
      
      llvm-svn: 164885
      a2e7ea2f
    • Evan Cheng's avatar
      Add test case for r164850. · 9e99f0c4
      Evan Cheng authored
      llvm-svn: 164867
      9e99f0c4
    • Evan Cheng's avatar
      Do not delete BBs if their addresses are taken. rdar://12396696 · 64a223ae
      Evan Cheng authored
      llvm-svn: 164866
      64a223ae
  4. Sep 28, 2012
  5. Sep 27, 2012
Loading