Skip to content
  1. Oct 05, 2013
  2. Oct 04, 2013
    • Eric Christopher's avatar
      Temporarily revert r176882 as it needs to be implemented in a different · c19d6f09
      Eric Christopher authored
      way for all platforms.
      
      llvm-svn: 191975
      c19d6f09
    • Eric Christopher's avatar
      Temporarily revert r191792 as it is causing some LTO debug failures · e595bae4
      Eric Christopher authored
      on platforms with relocations in debug info and also temporarily
      revert r191800 due to conflicts with the revert of r191792.
      
      llvm-svn: 191967
      e595bae4
    • Matthias Braun's avatar
      Fix comment · caff7647
      Matthias Braun authored
      llvm-svn: 191966
      caff7647
    • Matthias Braun's avatar
      Fix indentation · 6a57acf4
      Matthias Braun authored
      llvm-svn: 191965
      6a57acf4
    • Matthias Braun's avatar
      Fix typo · c9d5c0f2
      Matthias Braun authored
      llvm-svn: 191964
      c9d5c0f2
    • Craig Topper's avatar
      Revert r191940 to see if it fixes the build bots. · d9a6cc03
      Craig Topper authored
      llvm-svn: 191941
      d9a6cc03
    • Craig Topper's avatar
      Add OPC_CheckChildSame0-3 to the DAG isel matcher. This replaces sequences of... · a2efe9eb
      Craig Topper authored
      Add OPC_CheckChildSame0-3 to the DAG isel matcher. This replaces sequences of MoveChild, CheckSame, MoveParent. Saves 846 bytes from the X86 DAG isel matcher, ~300 from ARM, ~840 from Hexagon.
      
      llvm-svn: 191940
      a2efe9eb
    • David Blaikie's avatar
      DebugInfo: Fix ordering of members after r191928 · 309ffe40
      David Blaikie authored
      In the case (shown in the attached test) where a member function
      definition was emitted into debug info the following could occur:
      
      1) build the debug info for the member function definition
      2) in (1), build the debug info for the member function declaration
      3) construct and add the member function declaration DIE
      4) add it to its context
      5) build its context (the type it is a member of)
      6) construct the members and add them to the type
      7) except don't add member functions because "getOrCreateSubprogram"
      adds the function to its parent anyway
      8) except we're only partway through building this subprogram
      declaration so it hasn't been added yet - but we returned the partially
      constructed DIE (since it's already in the MDNode->DIE mapping to avoid
      infinitely recursing trying to create the member function DIE)
      9) once the type is constructed, add the member function to it
      10) now the members are out of order (the member function being defined
      is listed as the last member, even though it was declared as the first)
      
      To avoid this, construct the context of the subprogram DIE before we
      query to see if it exists. That way we never end up creating it before
      creating its context and ending up in this situation.
      
      Alternatively, the type construction that visits/builds all the members
      could call something like getOrCreateSubprogram, but that doesn't ever
      do the "add to context" step. Then the type building code would always
      be responsible for adding members (and the subprogram "addToContextDIE"
      would no-op because the context building would have added the subprogram
      declaration to the type/context DIE already).
      
      (the test cases updated were overly-sensitive to offsets or abbreviation
      numbers. We don't have a nice way to make these tests more robust as yet
      - multiline FileCheck matches would be required)
      
      llvm-svn: 191939
      309ffe40
    • Richard Mitton's avatar
      Fixed a bug with section names containing special characters. · c2508247
      Richard Mitton authored
      Changed the dwarf aranges code to not use getLabelEndName, as it turns out it's not reliable to call that given user-defined section names. Section names can have characters in that aren't representable as symbol names.
      
      The dwarf-aranges test case has been updated to include a special character, to check this.
      
      This fixes pr17416.
      
      llvm-svn: 191932
      c2508247
  3. Oct 03, 2013
    • David Blaikie's avatar
      DebugInfo: Avoid redundantly adding child DIEs to parents. · 811bfe63
      David Blaikie authored
      DIE::addChild had a shortcircuit that silently no-op'd when a child was
      readded to the same parent. This hid some quirky/redundant code in
      DwarfDebug/CompileUnit. By removing that functionality and replacing it
      with an assert I was able to find and cleanup those cases, mostly
      centering around adding members to types in various circumstances.
      
      1) The original oddity I noticed while working on type units (which
      actually was helping me in the short term, by accident) was the
      addToContextOwner call in constructTypeDIE. This call was completely
      bogus (why was it only done for non-virtual types? what relevance does
      that have at all) and redundant with the more uniform addToContextOwner
      made in getOrCreateTypeDIE.
      
      2) If a member function definition was visited (createSubprogramDIE), it
      would attempt to build the member function declaration. The declaration
      DIE would then be added to its context, but in building the context (the
      type for which this function is a member) the members of the type would
      be added to the type automatically, so by the time the context was
      constructed, the member function was already associated with it.
      
      3) The same as (2) but without the member function being constructed
      first. Whenever a type was constructed, the members would be created and
      member functions would be created by getOrCreateSubprogramDIE - this
      would lead to the subprogram being added to the (incomplete) type
      already, then the general member-construction code would add it again.
      
      llvm-svn: 191928
      811bfe63
    • Matt Arsenault's avatar
      Rename DataLayout variables TD -> DL · 40dddd71
      Matt Arsenault authored
      llvm-svn: 191927
      40dddd71
    • Eric Christopher's avatar
      Make sure we emit a section for pubnames even if that section is · c948b9df
      Eric Christopher authored
      going to be empty. This is particularly important for the gnu
      pubnames case since we're emitting a relocation to the section.
      
      llvm-svn: 191915
      c948b9df
    • Eric Christopher's avatar
      Fix cut and paste typo. · f976c77e
      Eric Christopher authored
      llvm-svn: 191914
      f976c77e
    • Jin-Gu Kang's avatar
      Added checking code whehter target supports specific dag combining about rotate · 0bf8241d
      Jin-Gu Kang authored
      or not. The corresponding dag patterns are as following:
      
      "DAGCombier::MatchRotate" function in DAGCombiner.cpp
      Pattern1
      // fold (or (shl (*ext x), (*ext y)),
      //          (srl (*ext x), (*ext (sub 32, y)))) ->
      //   (*ext (rotl x, y))
      // fold (or (shl (*ext x), (*ext y)),
      //          (srl (*ext x), (*ext (sub 32, y)))) ->
      //   (*ext (rotr x, (sub 32, y)))
      
      pattern2
      // fold (or (shl (*ext x), (*ext (sub 32, y))),
      //          (srl (*ext x), (*ext y))) ->
      //   (*ext (rotl x, y))
      // fold (or (shl (*ext x), (*ext (sub 32, y))),
      //          (srl (*ext x), (*ext y))) ->
      //   (*ext (rotr x, (sub 32, y)))
      
      llvm-svn: 191905
      0bf8241d
    • Alexey Samsonov's avatar
      Remove wild .debug_aranges entries generated from unimportant labels · 4436bf03
      Alexey Samsonov authored
      r191052 added emitting .debug_aranges to Clang, but this
      functionality is broken: it uses all MC labels added in DWARF Asm
      printer, including the labels for build relocations between
      different DWARF sections, like .Lsection_line or .Ldebug_loc0.
      
      As a result, if any DIE .debug_info would contain "DW_AT_location=0x123"
      attribute, .debug_aranges would also contain a range starting from 0x123,
      breaking tools that rely on this section.
      
      This patch fixes this by using only MC labels that corresponds to the
      addresses in the user program.
      
      llvm-svn: 191884
      4436bf03
  4. Oct 02, 2013
    • Chandler Carruth's avatar
      Remove the very substantial, largely unmaintained legacy PGO · ea564946
      Chandler Carruth authored
      infrastructure.
      
      This was essentially work toward PGO based on a design that had several
      flaws, partially dating from a time when LLVM had a different
      architecture, and with an effort to modernize it abandoned without being
      completed. Since then, it has bitrotted for several years further. The
      result is nearly unusable, and isn't helping any of the modern PGO
      efforts. Instead, it is getting in the way, adding confusion about PGO
      in LLVM and distracting everyone with maintenance on essentially dead
      code. Removing it paves the way for modern efforts around PGO.
      
      Among other effects, this removes the last of the runtime libraries from
      LLVM. Those are being developed in the separate 'compiler-rt' project
      now, with somewhat different licensing specifically more approriate for
      runtimes.
      
      llvm-svn: 191835
      ea564946
    • Manman Ren's avatar
      Debug Info: In DIBuilder, the derived-from field of a DW_TAG_pointer_type · 9a0a6703
      Manman Ren authored
      is updated to use DITypeRef.
      
      Move isUnsignedDIType and getOriginalTypeSize from DebugInfo.h to be static
      helper functions in DwarfCompileUnit. We already have a static helper function
      "isTypeSigned" in DwarfCompileUnit, and a pointer to DwarfDebug is added to
      resolve the derived-from field. All three functions need to go across link
      for derived-from fields, so we need to get hold of a type identifier map.
      
      A pointer to DwarfDebug is also added to DbgVariable in order to resolve the
      derived-from field.
      
      Debug info verifier is updated to check a derived-from field is a TypeRef.
      Verifier will not go across link for derived-from fields, in debug info finder,
      we go across the link to add derived-from fields to types.
      
      Function getDICompositeType is only used by dragonegg and since dragonegg does
      not generate identifier for types, we use an empty map to resolve the
      derived-from field.
      
      When printing a derived-from field, we use DITypeRef::getName to either return
      the type identifier or getName of the DIType.
      
      A paired commit at clang is required due to changes to DIBuilder.
      
      llvm-svn: 191800
      9a0a6703
  5. Oct 01, 2013
Loading