Skip to content
  1. Jan 07, 2013
    • Craig Topper's avatar
      Remove unnecessary # tokens at the beginning and end of defm names. · bd62d64c
      Craig Topper authored
      llvm-svn: 171694
      bd62d64c
    • Chandler Carruth's avatar
      Fix the enumerator names for ShuffleKind to match tho coding standards, · 2109f47d
      Chandler Carruth authored
      and make its comments doxygen comments.
      
      llvm-svn: 171688
      2109f47d
    • Chandler Carruth's avatar
      Make the popcnt support enums and methods have more clear names and · 50a36cd1
      Chandler Carruth authored
      follow the conding conventions regarding enumerating a set of "kinds" of
      things.
      
      llvm-svn: 171687
      50a36cd1
    • Chandler Carruth's avatar
      Move TargetTransformInfo to live under the Analysis library. This no · d3e73556
      Chandler Carruth authored
      longer would violate any dependency layering and it is in fact an
      analysis. =]
      
      llvm-svn: 171686
      d3e73556
    • Chandler Carruth's avatar
      Switch TargetTransformInfo from an immutable analysis pass that requires · 664e354d
      Chandler Carruth authored
      a TargetMachine to construct (and thus isn't always available), to an
      analysis group that supports layered implementations much like
      AliasAnalysis does. This is a pretty massive change, with a few parts
      that I was unable to easily separate (sorry), so I'll walk through it.
      
      The first step of this conversion was to make TargetTransformInfo an
      analysis group, and to sink the nonce implementations in
      ScalarTargetTransformInfo and VectorTargetTranformInfo into
      a NoTargetTransformInfo pass. This allows other passes to add a hard
      requirement on TTI, and assume they will always get at least on
      implementation.
      
      The TargetTransformInfo analysis group leverages the delegation chaining
      trick that AliasAnalysis uses, where the base class for the analysis
      group delegates to the previous analysis *pass*, allowing all but tho
      NoFoo analysis passes to only implement the parts of the interfaces they
      support. It also introduces a new trick where each pass in the group
      retains a pointer to the top-most pass that has been initialized. This
      allows passes to implement one API in terms of another API and benefit
      when some other pass above them in the stack has more precise results
      for the second API.
      
      The second step of this conversion is to create a pass that implements
      the TargetTransformInfo analysis using the target-independent
      abstractions in the code generator. This replaces the
      ScalarTargetTransformImpl and VectorTargetTransformImpl classes in
      lib/Target with a single pass in lib/CodeGen called
      BasicTargetTransformInfo. This class actually provides most of the TTI
      functionality, basing it upon the TargetLowering abstraction and other
      information in the target independent code generator.
      
      The third step of the conversion adds support to all TargetMachines to
      register custom analysis passes. This allows building those passes with
      access to TargetLowering or other target-specific classes, and it also
      allows each target to customize the set of analysis passes desired in
      the pass manager. The baseline LLVMTargetMachine implements this
      interface to add the BasicTTI pass to the pass manager, and all of the
      tools that want to support target-aware TTI passes call this routine on
      whatever target machine they end up with to add the appropriate passes.
      
      The fourth step of the conversion created target-specific TTI analysis
      passes for the X86 and ARM backends. These passes contain the custom
      logic that was previously in their extensions of the
      ScalarTargetTransformInfo and VectorTargetTransformInfo interfaces.
      I separated them into their own file, as now all of the interface bits
      are private and they just expose a function to create the pass itself.
      Then I extended these target machines to set up a custom set of analysis
      passes, first adding BasicTTI as a fallback, and then adding their
      customized TTI implementations.
      
      The fourth step required logic that was shared between the target
      independent layer and the specific targets to move to a different
      interface, as they no longer derive from each other. As a consequence,
      a helper functions were added to TargetLowering representing the common
      logic needed both in the target implementation and the codegen
      implementation of the TTI pass. While technically this is the only
      change that could have been committed separately, it would have been
      a nightmare to extract.
      
      The final step of the conversion was just to delete all the old
      boilerplate. This got rid of the ScalarTargetTransformInfo and
      VectorTargetTransformInfo classes, all of the support in all of the
      targets for producing instances of them, and all of the support in the
      tools for manually constructing a pass based around them.
      
      Now that TTI is a relatively normal analysis group, two things become
      straightforward. First, we can sink it into lib/Analysis which is a more
      natural layer for it to live. Second, clients of this interface can
      depend on it *always* being available which will simplify their code and
      behavior. These (and other) simplifications will follow in subsequent
      commits, this one is clearly big enough.
      
      Finally, I'm very aware that much of the comments and documentation
      needs to be updated. As soon as I had this working, and plausibly well
      commented, I wanted to get it committed and in front of the build bots.
      I'll be doing a few passes over documentation later if it sticks.
      
      Commits to update DragonEgg and Clang will be made presently.
      
      llvm-svn: 171681
      664e354d
  2. Jan 06, 2013
    • Craig Topper's avatar
      Fix suffix handling for parsing and printing of cvtsi2ss, cvtsi2sd, cvtss2si,... · 4f1c7256
      Craig Topper authored
      Fix suffix handling for parsing and printing of cvtsi2ss, cvtsi2sd, cvtss2si, cvttss2si, cvtsd2si, and cvttsd2si to match gas behavior.
      
      cvtsi2* should parse with an 'l' or 'q' suffix or no suffix at all. No suffix should be treated the same as 'l' suffix. Printing should always print a suffix. Previously we didn't parse or print an 'l' suffix.
      cvtt*2si/cvt*2si should parse with an 'l' or 'q' suffix or not suffix at all. No suffix should use the destination register size to choose encoding. Printing should not print a suffix.
      
      Original 'l' suffix issue with cvtsi2* pointed out by Michael Kuperstein.
      
      llvm-svn: 171668
      4f1c7256
    • Evan Cheng's avatar
      Fix for PR14739. It's not safe to fold a load into a call across a store.... · 3fb03e23
      Evan Cheng authored
      Fix for PR14739. It's not safe to fold a load into a call across a store. Thanks to Nick Lewycky for the initial patch.
      
      llvm-svn: 171665
      3fb03e23
  3. Jan 05, 2013
  4. Jan 04, 2013
    • Preston Gurd's avatar
      The current Intel Atom microarchitecture has a feature whereby when a function · e36b685a
      Preston Gurd authored
      returns early then it is slightly faster to execute a sequence of NOP
      instructions to wait until the return address is ready,
      as opposed to simply stalling on the ret instruction
      until the return address is ready.
      
      When compiling for X86 Atom only, this patch will run a pass, called
      "X86PadShortFunction" which will add NOP instructions where less than four
      cycles elapse between function entry and return.
      
      It includes tests.
      
      Patch by Andy Zhang.
      
      llvm-svn: 171524
      e36b685a
    • Nadav Rotem's avatar
      LoopVectorizer: · e1d5c4b8
      Nadav Rotem authored
      1. Add code to estimate register pressure.
      2. Add code to select the unroll factor based on register pressure.
      3. Add bits to TargetTransformInfo to provide the number of registers.
      
      llvm-svn: 171469
      e1d5c4b8
    • Nadav Rotem's avatar
      · c616a540
      Nadav Rotem authored
      Revert revision: 171467. This transformation is incorrect and makes some tests fail. Original message:
      
      Simplified TRUNCATE operation that comes after SETCC. It is possible since SETCC result is 0 or -1.
      Added a test.
      
      llvm-svn: 171468
      c616a540
  5. Jan 03, 2013
    • Elena Demikhovsky's avatar
    • Michael Gottesman's avatar
      Revert "Mark DIV/IDIV instructions hasSideEffects=1 because they can trap when... · 820aac1c
      Michael Gottesman authored
      Revert "Mark DIV/IDIV instructions hasSideEffects=1 because they can trap when dividing by 0. This is needed to keep early if conversion from moving them across basic blocks."
      
      This reverts commit r171461 since it breaks the following tests:
      
      Clang :: Analysis/outofbound-notwork.c
      Clang :: Analysis/string-fail.c
      Clang :: CXX/basic/basic.lookup/basic.lookup.qual/p6-0x.cpp
      Clang :: CXX/basic/basic.lookup/basic.lookup.unqual/p15.cpp
      Clang :: CXX/dcl.dcl/dcl.spec/dcl.fct.spec/p4.cpp
      Clang :: CXX/dcl.dcl/dcl.spec/dcl.stc/p10.cpp
      Clang :: CXX/temp/temp.param/p14.cpp
      Clang :: CXX/temp/temp.res/temp.dep.res/temp.point/p1.cpp
      Clang :: CodeGen/2009-02-13-zerosize-union-field-ppc.c
      Clang :: CodeGen/blocks-2.c
      Clang :: CodeGen/libcalls-d.c
      Clang :: CodeGen/libcalls-ld.c
      Clang :: CodeGenCXX/conversion-function.cpp
      Clang :: CodeGenCXX/debug-info-limit-type.cpp
      Clang :: CodeGenCXX/inheriting-constructor.cpp
      Clang :: FixIt/fixit-errors.c
      Clang :: FixIt/fixit-pmem.cpp
      Clang :: Modules/namespaces.cpp
      Clang :: PCH/changed-files.c
      Clang :: PCH/pr4489.c
      Clang :: PCH/source-manager-stack.c
      Clang :: Parser/cxx-ambig-decl-expr-xfail.cpp
      Clang :: SemaCXX/switch-implicit-fallthrough-cxx98.cpp
      Clang :: SemaTemplate/instantiate-function-1.mm
      
      llvm-svn: 171466
      820aac1c
    • Craig Topper's avatar
      Mark DIV/IDIV instructions hasSideEffects=1 because they can trap when... · 7c27cc9f
      Craig Topper authored
      Mark DIV/IDIV instructions hasSideEffects=1 because they can trap when dividing by 0. This is needed to keep early if conversion from moving them across basic blocks.
      
      llvm-svn: 171461
      7c27cc9f
    • Hal Finkel's avatar
      Add a subtype parameter to VTTI::getShuffleCost · 95de3f30
      Hal Finkel authored
      In order to cost subvector insertion and extraction, we need to know
      the type of the subvector being extracted.
      
      No functionality change.
      
      llvm-svn: 171453
      95de3f30
  6. Jan 02, 2013
  7. Jan 01, 2013
  8. Dec 30, 2012
  9. Dec 29, 2012
  10. Dec 28, 2012
Loading