llvm-svn: 173827

if they were already concatenated in source using the spelling locations
even if they came from a macro expansion.

This fixes an issue where a GUID passed as macro argument ends up
malformed after preprocessing because we added spaces inside it.

rdar://13016645

llvm-svn: 173826

subsequent commands from being executed.

The diagnostics generation isn't designed for this use case, so add a note to
fix this in the very near future.  For now, just generated the diagnostics for
the first failing command.
Part of rdar://12984531

llvm-svn: 173825

llvm-svn: 173824

wchar_t causes problem with certain compilers. Removing it for now.

llvm-svn: 173823

llvm-svn: 173822

Before:
aaaaaaa(aaaaaa( // comment
                aaaaaaa));
<big mess>

After:
aaaaaaa(aaaaaa( // comment
    aaaaaaaa));
function(/* parameter 1 */ aaaaaaa,
         /* parameter 2 */ aaaaaaa,
         /* parameter 3 */ aaaaaaa,
         /* parameter 4 */ aaaaaaa);

(the latter example was only wrong in the one-arg-per-line mode, e.g. in
Google style).

llvm-svn: 173821

Provides the functionality for Clang change r172911 - I just had this still
lying around.

llvm-svn: 173820

llvm-svn: 173816

llvm-svn: 173815

llvm-svn: 173813

llvm-svn: 173812

Fixes accurately getting a cursor inside an objc container containing a struct definition,
from a PCH/preamble file.

rdar://12584613

llvm-svn: 173811

    
Fixed set-but-not-used warnings.

Reviewer: gribozavr
llvm-svn: 173810

No intended functionality change.

llvm-svn: 173809

This sadly doesn't have a test for the final
output because llvm-objdump can't dump relocations
that don't belong to a section :(

llvm-svn: 173808

llvm-svn: 173807

The style guide only forbids this for function declarations. So,
now

someFunction(
    aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa, aaaaaaaaaaaa);

Is allowed in Chromium mode.

llvm-svn: 173806

It needs to be compatible with C++03.

llvm-svn: 173805

Don't touch I->first on the end iterator, I == E!

llvm-svn: 173804

llvm-svn: 173803

Fix a crash in OpenCL code by using the proper (RHS) bit-width.

llvm-svn: 173802

This is
a) More efficient.
b) Important as we move forward with further metrics for penalty.

No functional changes intended.

llvm-svn: 173801

Moved everything users are not supposed to use to a private interface header.
Documented all public interfaces. Made them safe to use even if built without
MemorySanitizer.

llvm-svn: 173800

llvm-svn: 173799

llvm-svn: 173798

llvm-svn: 173797

llvm-svn: 173796

llvm-svn: 173795

llvm-svn: 173794

Not all changes might be ideal, but IMO all are acceptable.

llvm-svn: 173793

Before:
  SomeType aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),
      aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();
After:
  SomeType aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),
           aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();

llvm-svn: 173792

Add a diagnostic for an OpenCL kernel with a pointer pointer argument.
Also refactor the surrounding code a little.

llvm-svn: 173791

llvm-svn: 173790

C++11 allows that.

llvm-svn: 173789

the diagnostic's warn_ name. Switch some places (notably C++11 attributes)
which really wanted an error over to a different diagnostic. Finally, suppress
the diagnostic entirely for __ptr32, __ptr64 and __w64, to avoid producing
diagnostics in important system headers.

llvm-svn: 173788

This needs some more thinking, e.g. for namespaces, chains of if-else
if, ...

llvm-svn: 173787

llvm-svn: 173786

Those empty lines waste vertical whitespace and almost never
increase readability.

Before:
void f() {
  DoSomething();

}

After:
void f() {
  DoSomething();
}

llvm-svn: 173785

llvm-svn: 173784