Skip to content
  1. Nov 01, 2007
    • Duncan Sands's avatar
      Executive summary: getTypeSize -> getTypeStoreSize / getABITypeSize. · 44b8721d
      Duncan Sands authored
      The meaning of getTypeSize was not clear - clarifying it is important
      now that we have x86 long double and arbitrary precision integers.
      The issue with long double is that it requires 80 bits, and this is
      not a multiple of its alignment.  This gives a primitive type for
      which getTypeSize differed from getABITypeSize.  For arbitrary precision
      integers it is even worse: there is the minimum number of bits needed to
      hold the type (eg: 36 for an i36), the maximum number of bits that will
      be overwriten when storing the type (40 bits for i36) and the ABI size
      (i.e. the storage size rounded up to a multiple of the alignment; 64 bits
      for i36).
      
      This patch removes getTypeSize (not really - it is still there but
      deprecated to allow for a gradual transition).  Instead there is:
      
      (1) getTypeSizeInBits - a number of bits that suffices to hold all
      values of the type.  For a primitive type, this is the minimum number
      of bits.  For an i36 this is 36 bits.  For x86 long double it is 80.
      This corresponds to gcc's TYPE_PRECISION.
      
      (2) getTypeStoreSizeInBits - the maximum number of bits that is
      written when storing the type (or read when reading it).  For an
      i36 this is 40 bits, for an x86 long double it is 80 bits.  This
      is the size alias analysis is interested in (getTypeStoreSize
      returns the number of bytes).  There doesn't seem to be anything
      corresponding to this in gcc.
      
      (3) getABITypeSizeInBits - this is getTypeStoreSizeInBits rounded
      up to a multiple of the alignment.  For an i36 this is 64, for an
      x86 long double this is 96 or 128 depending on the OS.  This is the
      spacing between consecutive elements when you form an array out of
      this type (getABITypeSize returns the number of bytes).  This is
      TYPE_SIZE in gcc.
      
      Since successive elements in a SequentialType (arrays, pointers
      and vectors) need to be aligned, the spacing between them will be
      given by getABITypeSize.  This means that the size of an array
      is the length times the getABITypeSize.  It also means that GEP
      computations need to use getABITypeSize when computing offsets.
      Furthermore, if an alloca allocates several elements at once then
      these too need to be aligned, so the size of the alloca has to be
      the number of elements multiplied by getABITypeSize.  Logically
      speaking this doesn't have to be the case when allocating just
      one element, but it is simpler to also use getABITypeSize in this
      case.  So alloca's and mallocs should use getABITypeSize.  Finally,
      since gcc's only notion of size is that given by getABITypeSize, if
      you want to output assembler etc the same as gcc then getABITypeSize
      is the size you want.
      
      Since a store will overwrite no more than getTypeStoreSize bytes,
      and a read will read no more than that many bytes, this is the
      notion of size appropriate for alias analysis calculations.
      
      In this patch I have corrected all type size uses except some of
      those in ScalarReplAggregates, lib/Codegen, lib/Target (the hard
      cases).  I will get around to auditing these too at some point,
      but I could do with some help.
      
      Finally, I made one change which I think wise but others might
      consider pointless and suboptimal: in an unpacked struct the
      amount of space allocated for a field is now given by the ABI
      size rather than getTypeStoreSize.  I did this because every
      other place that reserves memory for a type (eg: alloca) now
      uses getABITypeSize, and I didn't want to make an exception
      for unpacked structs, i.e. I did it to make things more uniform.
      This only effects structs containing long doubles and arbitrary
      precision integers.  If someone wants to pack these types more
      tightly they can always use a packed struct.
      
      llvm-svn: 43620
      44b8721d
  2. Oct 31, 2007
  3. Oct 03, 2007
  4. Oct 01, 2007
  5. Sep 25, 2007
  6. Sep 24, 2007
  7. Sep 19, 2007
  8. Sep 18, 2007
  9. Aug 21, 2007
  10. Aug 18, 2007
  11. Jul 31, 2007
  12. Jul 30, 2007
  13. Jun 08, 2007
  14. Jun 07, 2007
  15. Jun 05, 2007
  16. Jun 04, 2007
  17. Jun 03, 2007
  18. Jun 02, 2007
  19. May 30, 2007
  20. May 06, 2007
  21. May 03, 2007
  22. May 02, 2007
  23. May 01, 2007
  24. Apr 25, 2007
  25. Apr 24, 2007
  26. Apr 21, 2007
  27. Apr 20, 2007
  28. Apr 18, 2007
  29. Apr 17, 2007
  30. Apr 15, 2007
  31. Mar 22, 2007
  32. Mar 07, 2007
  33. Feb 06, 2007
  34. Feb 02, 2007
    • Reid Spencer's avatar
      Changes to support making the shift instructions be true BinaryOperators. · 2341c22e
      Reid Spencer authored
      This feature is needed in order to support shifts of more than 255 bits
      on large integer types.  This changes the syntax for llvm assembly to
      make shl, ashr and lshr instructions look like a binary operator:
         shl i32 %X, 1
      instead of
         shl i32 %X, i8 1
      Additionally, this should help a few passes perform additional optimizations.
      
      llvm-svn: 33776
      2341c22e
  35. Jan 31, 2007
  36. Dec 23, 2006
    • Reid Spencer's avatar
      For PR950: · 266e42b3
      Reid Spencer authored
      This patch removes the SetCC instructions and replaces them with the ICmp
      and FCmp instructions. The SetCondInst instruction has been removed and
      been replaced with ICmpInst and FCmpInst.
      
      llvm-svn: 32751
      266e42b3
  37. Dec 19, 2006
  38. Dec 06, 2006
  39. Nov 27, 2006
    • Reid Spencer's avatar
      For PR950: · 6c38f0bb
      Reid Spencer authored
      The long awaited CAST patch. This introduces 12 new instructions into LLVM
      to replace the cast instruction. Corresponding changes throughout LLVM are
      provided. This passes llvm-test, llvm/test, and SPEC CPUINT2000 with the
      exception of 175.vpr which fails only on a slight floating point output
      difference.
      
      llvm-svn: 31931
      6c38f0bb
Loading