Skip to content
  1. Sep 09, 2008
  2. Sep 06, 2008
  3. Sep 05, 2008
    • Ted Kremenek's avatar
      Change struct forward declarations and definitions to use unique RecordDecls,... · 21475702
      Ted Kremenek authored
      Change struct forward declarations and definitions to use unique RecordDecls, as opposed to creating a single RecordDecl and reusing it.
      
      This change effects both RecordDecls and CXXRecordDecls, but does not effect EnumDecls (yet).
      
      The motivation of this patch is as follows:
      - Capture more source information, necessary for refactoring/rewriting clients.
      
      - Pave the way to resolve ownership issues with RecordDecls with the forthcoming
        addition of DeclGroups.
      
      Current caveats:
      - Until DeclGroups are in place, we will leak RecordDecls not explicitly
        referenced by the AST.  For example:
      
          typedef struct { ... } x;  
      
        The RecordDecl for the struct will be leaked because the TypedefDecl doesn't
        refer to it.  This will be solved with DeclGroups.
        
      - This patch also (temporarily) breaks CodeGen.  More below.
      
      High-level changes:
      - As before, TagType still refers to a TagDecl, but it doesn't own it.  When
        a struct/union/class is first referenced, a RecordType and RecordDecl are
        created for it, and the RecordType refers to that RecordDecl.  Later, if
        a new RecordDecl is created, the pointer to a RecordDecl in RecordType is
        updated to point to the RecordDecl that defines the struct/union/class.
      
      - TagDecl and RecordDecl now how a method 'getDefinition()' to return the
        TagDecl*/RecordDecl* that refers to the TagDecl* that defines a particular
        enum/struct/class/union. This is useful from going from a RecordDecl* that
        defines a forward declaration to the RecordDecl* that provides the actual
        definition. Note that this also works for EnumDecls, except that in this case
        there is no distinction between forward declarations and definitions (yet).
      
      - Clients should no longer assume that 'isDefinition()' returns true from a
        RecordDecl if the corresponding struct/union/class has been defined.
        isDefinition() only returns true if a particular RecordDecl is the defining
        Decl. Use 'getDefinition()' instead to determine if a struct has been defined.
      
      - The main changes to Sema happen in ActOnTag. To make the changes more
        incremental, I split off the processing of enums and structs et al into two
        code paths. Enums use the original code path (which is in ActOnTag) and
        structs use the ActOnTagStruct. Eventually the two code paths will be merged,
        but the idea was to preserve the original logic both for comparison and not to
        change the logic for both enums and structs all at once.
      
      - There is NO CHAINING of RecordDecls for the same RecordType. All RecordDecls
        that correspond to the same type simply have a pointer to that type. If we
        need to figure out what are all the RecordDecls for a given type we can build
        a backmap.
      
      - The diff in CXXRecordDecl.[cpp,h] is actually very small; it just mimics the
        changes to RecordDecl. For some reason 'svn' marks the entire file as changed.
      
      Why is CodeGen broken:
      - Codegen assumes that there is an equivalence between RecordDecl* and
        RecordType*. This was true before because we only created one RecordDecl* for
        a given RecordType*, but it is no longer true. I believe this shouldn't be too
        hard to change, but the patch was big enough as it is.
        
      I have tested this patch on both the clang test suite, and by running the static analyzer over Postgresql and a large Apple-internal project (mix of Objective-C and C).  
      
      llvm-svn: 55839
      21475702
    • Ted Kremenek's avatar
      Remove "NextDecl" from RecordDecl. This change touches many files that where... · 47923c7e
      Ted Kremenek authored
      Remove "NextDecl" from RecordDecl.  This change touches many files that where RecordDecl or CXXRecordDecl was constructed, always with an argument of 'NULL' for the previous declaration.
      
      The motivation behind this change is that chaining the RecordDecls is simply unnecessary.  Once we create multiple RecordDecls for the same struct/union/class, clients that care about all the declarations of the same struct can build a back map by seeing which Decls refer to the same RecordType.
      
      llvm-svn: 55821
      47923c7e
  4. Sep 04, 2008
  5. Aug 30, 2008
  6. Aug 28, 2008
  7. Aug 27, 2008
  8. Aug 22, 2008
  9. Aug 14, 2008
  10. Aug 11, 2008
    • Daniel Dunbar's avatar
      More #include cleaning · 56fdb6ae
      Daniel Dunbar authored
       - Kill unnecessary #includes in .cpp files. This is an automatic
         sweep so some things removed are actually used, but happen to be
         included by a previous header. I tried to get rid of the obvious
         examples and this was the easiest way to trim the #includes in one
         fell swoop.
       - We now return to regularly scheduled development.
      
      llvm-svn: 54632
      56fdb6ae
    • Daniel Dunbar's avatar
      More #include cleaning · 221fa94e
      Daniel Dunbar authored
       - Drop Expr.h,RecordLayout.h from ASTContext.h (for DeclBase.h and
         SourceLocation.h)
       - Move ASTContext constructor into implementation
      
      llvm-svn: 54627
      221fa94e
  11. Aug 09, 2008
  12. Aug 07, 2008
  13. Aug 04, 2008
    • Chris Lattner's avatar
      · 7adf0760
      Chris Lattner authored
      Finally fix PR2189.  This makes a fairly invasive but important change to
      move getAsArrayType into ASTContext instead of being a method on type.
      This is required because getAsArrayType(const AT), where AT is a typedef
      for "int[10]" needs to return ArrayType(const int, 10).
      
      Fixing this greatly simplifies getArrayDecayedType, which is a good sign.
      
      llvm-svn: 54317
      7adf0760
  14. Jul 26, 2008
  15. Jul 25, 2008
  16. Jun 30, 2008
    • Chris Lattner's avatar
      Make a few related changes: · 9a8d1d9e
      Chris Lattner authored
      1) add a new ASTContext::getFloatTypeSemantics method.
      2) Use it from SemaExpr.cpp, CodeGenTypes.cpp and other places.
      3) Change the TargetInfo.h get*Format methods to return their 
         fltSemantics byref instead of by pointer.
      4) Change CodeGenFunction::EmitBuiltinExpr to allow builtins which
         sometimes expand specially and othertimes fall back to libm.
      5) Add support for __builtin_nan("") to codegen, cases that don't pass
         in an empty string are currently lowered to libm calls.
      6) Fix codegen of __builtin_infl.
      
      llvm-svn: 52914
      9a8d1d9e
  17. Jun 28, 2008
  18. Jun 10, 2008
    • Argyrios Kyrtzidis's avatar
      -Changes to TagDecl: · 554a07ba
      Argyrios Kyrtzidis authored
        Added TagKind enum.
        Added getTagKind() method.
        Added convenience methods: isEnum(), isStruct(), isUnion(), isClass().
      -RecordDecl/CXXRecordDecl::Create() accept a TagKind enum instead of a DeclKind one.
      
      llvm-svn: 52160
      554a07ba
  19. Jun 06, 2008
  20. Jun 04, 2008
  21. May 30, 2008
  22. May 27, 2008
  23. May 21, 2008
Loading