Skip to content
  1. Nov 13, 2010
  2. Oct 26, 2010
  3. Oct 19, 2010
  4. Oct 15, 2010
    • Douglas Gregor's avatar
      When performing typo correction, look through the set of known · 57756eab
      Douglas Gregor authored
      identifiers to determine good typo-correction candidates. Once we've
      identified those candidates, we perform name lookup on each of them
      and the consider the results. 
      
      This optimization makes typo correction > 2x faster on a benchmark
      example using a single typo (NSstring) in a tiny file that includes
      Cocoa.h from a precompiled header, since we are deserializing far less
      information now during typo correction.
      
      There is a semantic change here, which is interesting. The presence of
      a similarly-named entity that is not visible can now affect typo
      correction. This is both good (you won't get weird corrections if the
      thing you wanted isn't in scope) and bad (you won't get good
      corrections if there is a similarly-named-but-completely-unrelated
      thing). Time will tell whether it was a good choice or not.
      
      llvm-svn: 116528
      57756eab
  5. Oct 14, 2010
  6. Sep 24, 2010
  7. Sep 16, 2010
    • Douglas Gregor's avatar
      Implement automatic bracket insertion for Objective-C class message · abf4a3e4
      Douglas Gregor authored
      sends. These are far trickier than instance messages, because we
      typically have something like
      
        NSArray alloc]
      
      where it appears to be a declaration of a variable named "alloc" up
      until we see the ']' (or a ':'), and at that point we can't backtrace.
      So, we use a combination of syntactic and semantic disambiguation to
      treat this as a message send only when the type is an Objective-C type
      and it has the syntax of a class message send (which would otherwise
      be ill-formed).
      
      llvm-svn: 114057
      abf4a3e4
    • Douglas Gregor's avatar
      Handle bracket insertion for Objective-C class messages in a very · 3e972009
      Douglas Gregor authored
      narrow, almost useless case where we're inside a parenthesized
      expression, e.g.,
      
        (NSArray alloc])
      
      The solution to the general case still eludes me.
      
      llvm-svn: 114039
      3e972009
  8. Sep 15, 2010
    • Douglas Gregor's avatar
      Implement bracket insertion for Objective-C instance message sends as · e9bba4f1
      Douglas Gregor authored
      part of parser recovery. For example, given:
      
        a method1:arg];
      
      we detect after parsing the expression "a" that we have the start of a
      message send expression. We pretend we've seen a '[' prior to the a,
      then parse the remainder as a message send. We'll then give a
      diagnostic+fix-it such as:
      
      fixit-objc-message.m:17:3: error: missing '[' at start of message
            send expression
        a method1:arg];
        ^
        [
      
      The algorithm here is very simple, and always assumes that the open
      bracket goes at the beginning of the message send. It also only works
      for non-super instance message sends at this time.
      
      llvm-svn: 113968
      e9bba4f1
  9. Aug 27, 2010
  10. Aug 26, 2010
  11. Aug 25, 2010
  12. Aug 24, 2010
  13. Aug 17, 2010
  14. Aug 12, 2010
  15. Aug 10, 2010
  16. Aug 03, 2010
  17. Jul 25, 2010
  18. Jul 23, 2010
  19. Jul 22, 2010
  20. Jul 13, 2010
    • Douglas Gregor's avatar
      When forming a function call or message send expression, be sure to · 603d81bf
      Douglas Gregor authored
      strip cv-qualifiers from the expression's type when the language calls
      for it: in C, that's all the time, while C++ only does it for
      non-class types. 
      
      Centralized the computation of the call expression type in
      QualType::getCallResultType() and some helper functions in other nodes
      (FunctionDecl, ObjCMethodDecl, FunctionType), and updated all relevant
      callers of getResultType() to getCallResultType().
      
      Fixes PR7598 and PR7463, along with a bunch of getResultType() call
      sites that weren't stripping references off the result type (nothing
      stripped cv-qualifiers properly before this change).
      
      llvm-svn: 108234
      603d81bf
  21. Jun 16, 2010
  22. May 22, 2010
    • Douglas Gregor's avatar
      Improve our handling of reference binding for subobjects of · aae38d66
      Douglas Gregor authored
      temporaries. There are actually several interrelated fixes here:
      
        - When converting an object to a base class, it's only an lvalue
        cast when the original object was an lvalue and we aren't casting
        pointer-to-derived to pointer-to-base. Previously, we were
        misclassifying derived-to-base casts of class rvalues as lvalues,
        causing various oddities (including problems with reference binding
        not extending the lifetimes of some temporaries).
      
        - Teach the code for emitting a reference binding how to look
        through no-op casts and parentheses directly, since
        Expr::IgnoreParenNoOpCasts is just plain wrong for this. Also, make
        sure that we properly look through multiple levels of indirection
        from the temporary object, but destroy the actual temporary object;
        this fixes the reference-binding issue mentioned above.
      
        - Teach Objective-C message sends to bind the result as a temporary
          when needed. This is actually John's change, but it triggered the
          reference-binding problem above, so it's included here. Now John
          can actually test his return-slot improvements.
      
      llvm-svn: 104434
      aae38d66
  23. May 20, 2010
  24. May 16, 2010
  25. May 15, 2010
    • John McCall's avatar
      Substantially alter the design of the Objective C type AST by introducing · 8b07ec25
      John McCall authored
      ObjCObjectType, which is basically just a pair of
        one of {primitive-id, primitive-Class, user-defined @class}
      with
        a list of protocols.
      An ObjCObjectPointerType is therefore just a pointer which always points to
      one of these types (possibly sugared).  ObjCInterfaceType is now just a kind
      of ObjCObjectType which happens to not carry any protocols.
      
      Alter a rather large number of use sites to use ObjCObjectType instead of
      ObjCInterfaceType.  Store an ObjCInterfaceType as a pointer on the decl rather
      than hashing them in a FoldingSet.  Remove some number of methods that are no
      longer used, at least after this patch.
      
      By simplifying ObjCObjectPointerType, we are now able to easily remove and apply
      pointers to Objective-C types, which is crucial for a certain kind of ObjC++
      metaprogramming common in WebKit.
      
      llvm-svn: 103870
      8b07ec25
  26. May 13, 2010
  27. Apr 24, 2010
  28. Apr 22, 2010
  29. Apr 21, 2010
Loading