Skip to content
  1. Aug 12, 2004
  2. Aug 07, 2004
  3. Aug 04, 2004
  4. Aug 02, 2004
  5. Aug 01, 2004
  6. Jul 31, 2004
  7. Jul 29, 2004
  8. Jul 28, 2004
  9. Jul 25, 2004
    • Alkis Evlogimenos's avatar
      Add some comments to the backtracking code. · 83d9b62b
      Alkis Evlogimenos authored
      llvm-svn: 15200
      83d9b62b
    • Chris Lattner's avatar
      Fix the sense of joinable · bbe845b9
      Chris Lattner authored
      llvm-svn: 15196
      bbe845b9
    • Chris Lattner's avatar
      This patch makes use of the infrastructure implemented before to safely and · ccc75d4f
      Chris Lattner authored
      aggressively coallesce live ranges even if they overlap.  Consider this LLVM
      code for example:
      
      int %test(int %X) {
              %Y = mul int %X, 1      ;; Codegens to Y = X
              %Z = add int %X, %Y
              ret int %Z
      }
      
      The mul is just there to get a copy into the code stream.  This produces
      this machine code:
      
       (0x869e5a8, LLVM BB @0x869b9a0):
              %reg1024 = mov <fi#-2>, 1, %NOREG, 0    ;; "X"
              %reg1025 = mov %reg1024                 ;; "Y"  (subsumed by X)
              %reg1026 = add %reg1024, %reg1025
              %EAX = mov %reg1026
              ret
      
      Note that the life times of reg1024 and reg1025 overlap, even though they
      contain the same value.  This results in this machine code:
      
      test:
              mov %EAX, DWORD PTR [%ESP + 4]
              mov %ECX, %EAX
              add %EAX, %ECX
              ret
      
      Another, worse case involves loops and PHI nodes.  Consider this trivial loop:
      testcase:
      
      int %test2(int %X) {
      entry:
              br label %Loop
      Loop:
              %Y = phi int [%X, %entry], [%Z, %Loop]
              %Z = add int %Y, 1
              %cond = seteq int %Z, 100
              br bool %cond, label %Out, label %Loop
      Out:
              ret int %Z
      }
      
      Because of interactions between the PHI elimination pass and the register
      allocator, this got compiled to this code:
      
      test2:
              mov %ECX, DWORD PTR [%ESP + 4]
      .LBBtest2_1:
      ***     mov %EAX, %ECX
              inc %EAX
              cmp %EAX, 100
      ***     mov %ECX, %EAX
              jne .LBBtest2_1
      
              ret
      
      Or on powerpc, this code:
      
      _test2:
              mflr r0
              stw r0, 8(r1)
              stwu r1, -60(r1)
      .LBB_test2_1:
              addi r2, r3, 1
              cmpwi cr0, r2, 100
      ***     or r3, r2, r2
              bne cr0, .LBB_test2_1
      
      ***     or r3, r2, r2
              lwz r0, 68(r1)
              mtlr r0
              addi r1, r1, 60
              blr 0
      
      
      
      With this improvement in place, we now generate this code for these two
      testcases, which is what we want:
      
      
      test:
              mov %EAX, DWORD PTR [%ESP + 4]
              add %EAX, %EAX
              ret
      
      test2:
              mov %EAX, DWORD PTR [%ESP + 4]
      .LBBtest2_1:
              inc %EAX
              cmp %EAX, 100
              jne .LBBtest2_1 # Loop
              ret
      
      Or on PPC:
      
      _test2:
              mflr r0
              stw r0, 8(r1)
              stwu r1, -60(r1)
      .LBB_test2_1:
              addi r3, r3, 1
              cmpwi cr0, r3, 100
              bne cr0, .LBB_test2_1
      
              lwz r0, 68(r1)
              mtlr r0
              addi r1, r1, 60
              blr 0
      
      
      Static numbers for spill code loads/stores/reg-reg copies (smaller is better):
      
      em3d:       before: 47/25/26         after: 44/22/24
      164.gzip:   before: 433/245/310      after: 403/231/278
      175.vpr:    before: 3721/2189/1581   after: 4144/2081/1423
      176.gcc:    before: 26195/8866/9235  after: 25942/8082/8275
      186.crafty: before: 4295/2587/3079   after: 4119/2519/2916
      252.eon:    before: 12754/7585/5803  after: 12508/7425/5643
      256.bzip2:  before: 463/226/315      after: 482:241/309
      
      
      Runtime perf number samples on X86:
      
      gzip: before: 41.09 after: 39.86
      bzip2: runtime: before: 56.71s after: 57.07s
      gcc: before: 6.16 after: 6.12
      eon: before: 2.03s after: 2.00s
      llvm-svn: 15194
      ccc75d4f
    • Chris Lattner's avatar
      Make a method const, no functionality changes · c8002d49
      Chris Lattner authored
      llvm-svn: 15193
      c8002d49
    • Chris Lattner's avatar
      Fix a bug where we incorrectly value numbered the first PHI definition the · 83b9c50f
      Chris Lattner authored
      same as the PHI use.  This is not correct as the PHI use value is different
      depending on which branch is taken.  This fixes espresso with aggressive
      coallescing, and perhaps others.
      
      llvm-svn: 15189
      83b9c50f
    • Chris Lattner's avatar
      Fix a bug in the range remover · af7e898e
      Chris Lattner authored
      llvm-svn: 15188
      af7e898e
    • Chris Lattner's avatar
      Add debugging output for joining assignments · 0e58e5e4
      Chris Lattner authored
      llvm-svn: 15187
      0e58e5e4
  10. Jul 24, 2004
    • Alkis Evlogimenos's avatar
      Remove implementation of operator= and make it private so that it is · e0ab16fe
      Alkis Evlogimenos authored
      not used accidentally.
      
      llvm-svn: 15172
      e0ab16fe
    • Alkis Evlogimenos's avatar
      Change std::map<unsigned, LiveInterval*> into a std::map<unsigned, · cf72e7f8
      Alkis Evlogimenos authored
      LiveInterval>. This saves some space and removes the pointer
      indirection caused by following the pointer.
      
      llvm-svn: 15167
      cf72e7f8
    • Chris Lattner's avatar
      whoops, didn't mean to remove this · 8c595eb4
      Chris Lattner authored
      llvm-svn: 15157
      8c595eb4
    • Chris Lattner's avatar
      In the joiner, merge the small interval into the large interval. This restores · d9bbbb84
      Chris Lattner authored
      us back to taking about 10.5s on gcc, instead of taking 15.6s!  The net result
      is that my big patches have hand no significant effect on compile time or code
      quality.  heh.
      
      llvm-svn: 15156
      d9bbbb84
    • Chris Lattner's avatar
      Completely eliminate the intervals_ list. instead, the r2iMap_ maintains · c51866a2
      Chris Lattner authored
      ownership of the intervals.
      
      llvm-svn: 15155
      c51866a2
    • Chris Lattner's avatar
      Big change to compute logical value numbers for each LiveRange added to an · 7efcdb7c
      Chris Lattner authored
      Interval.  This generalizes the isDefinedOnce mechanism that we used before
      to help us coallesce ranges that overlap.  As part of this, every logical
      range with a different value is assigned a different number in the interval.
      For example, for code that looks like this:
      
      0  X = ...
      4  X += ...
        ...
      N    = X
      
      We now generate a live interval that contains two ranges: [2,6:0),[6,?:1)
      reflecting the fact that there are two different values in the range at
      different positions in the code.
      
      Currently we are not using this information at all, so this just slows down
      liveintervals.  In the future, this will change.
      
      Note that this change also substantially refactors the joinIntervalsInMachineBB
      method to merge the cases for virt-virt and phys-virt joining into a single
      case, adds comments, and makes the code a bit easier to follow.
      
      llvm-svn: 15154
      7efcdb7c
    • Chris Lattner's avatar
      Add a new differingRegisterClasses method · d7b9e293
      Chris Lattner authored
      make overlapsAliases take pointers instead of references
      fix indentation
      
      llvm-svn: 15153
      d7b9e293
    • Chris Lattner's avatar
      Little stuff: · 038747f5
      Chris Lattner authored
      * Fix comment typeo
      * add dump() methods
      * add a few new methods like getLiveRangeContaining, removeRange & joinable
        (which is currently the same as overlaps)
      * Remove the unused operator==
      
      Bigger change:
      
      * In LiveInterval, instead of using a boolean isDefinedOnce to keep track of
        if there are > 1 definitions in a particular interval, keep a counter,
        NumValues to keep track of exactly how many there are.
      * In LiveRange, add a new ValId element to indicate which of the numbered
        values each LiveRange belongs to.   We now no longer merge LiveRanges if
        they are of differing value ID's even if they are neighbors.
      
      llvm-svn: 15152
      038747f5
  11. Jul 23, 2004
    • Chris Lattner's avatar
      More minor changes: · 1604b02c
      Chris Lattner authored
       * Inline some functions
       * Eliminate some comparisons from the release build
      
      This is good for another .3 on gcc.
      
      llvm-svn: 15144
      1604b02c
Loading