Skip to content
  1. Oct 18, 2013
  2. Oct 17, 2013
    • Reid Kleckner's avatar
      [ms-cxxabi] Error out on virtual function memptrs · 5a823d5f
      Reid Kleckner authored
      These are uncommon and this is better than miscompiling.
      
      llvm-svn: 192923
      5a823d5f
    • Richard Mitton's avatar
      Added support for reading thread-local storage variables, as defined using the __thread modifier. · 0a558357
      Richard Mitton authored
      To make this work this patch extends LLDB to:
      
      - Explicitly track the link_map address for each module. This is effectively the module handle, not sure why it wasn't already being stored off anywhere. As an extension later, it would be nice if someone were to add support for printing this as part of the modules list.
      
      - Allow reading the per-thread data pointer via ptrace. I have added support for Linux here. I'll be happy to add support for FreeBSD once this is reviewed. OS X does not appear to have __thread variables, so maybe we don't need it there. Windows support should eventually be workable along the same lines.
      
      - Make DWARF expressions track which module they originated from.
      
      - Add support for the DW_OP_GNU_push_tls_address DWARF opcode, as generated by gcc and recent versions of clang. Earlier versions of clang (such as 3.2, which is default on Ubuntu right now) do not generate TLS debug info correctly so can not be supported here.
      
      - Understand the format of the pthread DTV block. This is where it gets tricky. We have three basic options here:
      
        1) Call "dlinfo" or "__tls_get_addr" on the inferior and ask it directly. However this won't work on core dumps, and generally speaking it's not a good idea for the debugger to call functions itself, as it has the potential to not work depending on the state of the target.
      
        2) Use libthread_db. This is what GDB does. However this option requires having a version of libthread_db on the host cross-compiled for each potential target. This places a large burden on the user, and would make it very hard to cross-debug from Windows to Linux, for example. Trying to build a library intended exclusively for one OS on a different one is not pleasant. GDB sidesteps the problem and asks the user to figure it out.
      
        3) Parse the DTV structure ourselves. On initial inspection this seems to be a bad option, as the DTV structure (the format used by the runtime to manage TLS data) is not in fact a kernel data structure, it is implemented entirely in useerland in libc. Therefore the layout of it's fields are version and OS dependent, and are not standardized.
      
        However, it turns out not to be such a problem. All OSes use basically the same algorithm (a per-module lookup table) as detailed in Ulrich Drepper's TLS ELF ABI document, so we can easily write code to decode it ourselves. The only question therefore is the exact field layouts required. Happily, the implementors of libpthread expose the structure of the DTV via metadata exported as symbols from the .so itself, designed exactly for this kind of thing. So this patch simply reads that metadata in, and re-implements libthread_db's algorithm itself. We thereby get cross-platform TLS lookup without either requiring third-party libraries, while still being independent of the version of libpthread being used.
      
      Test case included.
      
      llvm-svn: 192922
      0a558357
    • Alp Toker's avatar
      Revert "Fix missed exception spec checks and crashes" · be2a55f5
      Alp Toker authored
      The changes caused the sanitizer bot to hang:
        http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/2311
      
      Needs investigation.
      
      This reverts commit r192914.
      
      llvm-svn: 192921
      be2a55f5
    • Ed Maste's avatar
      Fix building with ENABLE_DEBUG_PRINTF · a0191d11
      Ed Maste authored
      Clang tells me that "token pasting of ',' and __VA_ARGS__ is a GNU
      extension".  Also catch up with changes in function args.
      
      llvm-svn: 192920
      a0191d11
    • Hans Wennborg's avatar
      Make .asm a valid extension for assembly files · cd2672c9
      Hans Wennborg authored
      This is a common extension on Windows, and now clang will assemble them
      instead of treating them as linker input which is the default for unknown
      file types.
      
      llvm-svn: 192919
      cd2672c9
    • Ed Maste's avatar
      Whitespace: replace 4-space-tabs with spaces · 4c24b126
      Ed Maste authored
      llvm-svn: 192918
      4c24b126
    • Richard Mitton's avatar
      Rearranged linker flags for test suite. · ec8b282b
      Richard Mitton authored
      Some linkers (GNU ld) are picky about library order, so if we import libraries as part of our LDFLAGS then that needs to come after any DYLIB_NAME which might require that library.
      
      llvm-svn: 192917
      ec8b282b
    • David Peixotto's avatar
      17309 ARM backend incorrectly lowers COPY_STRUCT_BYVAL_I32 for thumb1 targets · 8e5abc52
      David Peixotto authored
      This commit implements the correct lowering of the
      COPY_STRUCT_BYVAL_I32 pseudo-instruction for thumb1 targets.
      Previously, the lowering of COPY_STRUCT_BYVAL_I32 generated the
      post-increment forms of ldr/ldrh/ldrb instructions. Thumb1 does not
      have the post-increment form of these instructions so the generated
      assembly contained invalid instructions.
      
      Passing the generated assembly to gcc caused it to complain with an
      error like this:
      
        Error: cannot honor width suffix -- `ldrb r3,[r0],#1'
      
      and the integrated assembler would generate an object file with an
      invalid instruction encoding.
      
      This commit contains a small test case that demonstrates the problem
      with thumb1 targets as well as an expanded test case that more
      throughly tests the lowering of byval struct passing for arm,
      thumb1, and thumb2 targets.
      
      llvm-svn: 192916
      8e5abc52
    • David Peixotto's avatar
      Refactor lowering for COPY_STRUCT_BYVAL_I32 · c32e24a1
      David Peixotto authored
      This commit refactors the lowering of the COPY_STRUCT_BYVAL_I32
      pseudo-instruction in the ARM backend. We introduce a new helper
      class that encapsulates all of the operations needed during the
      lowering. The operations are implemented for each subtarget in
      different subclasses. Currently only arm and thumb2 subtargets are
      supported.
      
      This refactoring was done to easily implement support for thumb1
      subtargets. This initial patch does not add support for thumb1, but
      is only a refactoring. A follow on patch will implement the support
      for thumb1 subtargets.
      
      No intended functionality change.
      
      llvm-svn: 192915
      c32e24a1
    • Alp Toker's avatar
      Fix missed exception spec checks and crashes · de0be623
      Alp Toker authored
      Delayed exception specification checking for defaulted members and virtual
      destructors are both susceptible to mutation during iteration so we need to
      process the worklists fully.
      
      This resolves both accepts-invalid and rejects-valid issues and moreover fixes
      potential invalid memory access as the contents of the vectors change during
      iteration and recursive template instantiation.
      
      This patch also adds two assertions at end of TU to ensure no specs are left
      unchecked as was happenning before the fix, plus a test case from Marshall Clow
      for the defaulted member crash extracted from the libcxx headers.
      
      Reviewed by Richard Smith.
      
      llvm-svn: 192914
      de0be623
    • Anders Waldenborg's avatar
      llvm-c: Add LLVMIntPtrType{,ForAS}InContext · 959f0407
      Anders Waldenborg authored
      All of the Core API functions have versions which accept explicit context, in
      addition to ones which work on global context. This commit adds functions
      which accept explicit context to the Target API for consistency.
      
      Patch by Peter Zotov
      
      Differential Revision: http://llvm-reviews.chandlerc.com/D1912
      
      llvm-svn: 192913
      959f0407
    • Hans Wennborg's avatar
      CMake: set stack size for MSVC in just one place · bef50abe
      Hans Wennborg authored
      After r192904, Reid pointed out he thought we already set the stack
      size for MSVC. Turns out we did, but it didn't seem to work.
      
      This commit sets the stack size in a single place, using
      CMAKE_EXE_LINKER_FLAGS because that seems to be the way that works
      best.
      
      llvm-svn: 192912
      bef50abe
    • DeLesley Hutchins's avatar
      Consumed analysis: fix ICE in handling of loop source locations. · 6501320e
      DeLesley Hutchins authored
      llvm-svn: 192911
      6501320e
    • Rafael Espindola's avatar
      Rename fields of GlobalStatus to match the coding style. · 045a78fa
      Rafael Espindola authored
      llvm-svn: 192910
      045a78fa
    • Chad Rosier's avatar
      [AArch64] Add support for NEON scalar three register different instruction · e7465644
      Chad Rosier authored
      class.  The instruction class includes the signed saturating doubling
      multiply-add long, signed saturating doubling multiply-subtract long, and
      the signed saturating doubling multiply long instructions.
      
      llvm-svn: 192909
      e7465644
    • Chad Rosier's avatar
      [AArch64] Add support for NEON scalar three register different instruction · 37d29173
      Chad Rosier authored
      class.  The instruction class includes the signed saturating doubling
      multiply-add long, signed saturating doubling multiply-subtract long, and
      the signed saturating doubling multiply long instructions.
      
      llvm-svn: 192908
      37d29173
    • Rafael Espindola's avatar
      27797bae
    • Rafael Espindola's avatar
      Simplify the interface of AnalyzeGlobal a bit and rename to analyzeGlobal. · 026c9cbe
      Rafael Espindola authored
      No functionality change.
      
      llvm-svn: 192906
      026c9cbe
    • Edwin Vane's avatar
      Refactoring transform-specific options · dd8cc29c
      Edwin Vane authored
          
      Making the user null macros command-line option visible to the
      UseNullptrTransform class instead of being visible only to the match callback.
      
      llvm-svn: 192905
      dd8cc29c
    • Hans Wennborg's avatar
      CMake: set stack size to 2MB for MSVC builds · fd541f00
      Hans Wennborg authored
      Compiling under Visual C++ 2012 with the default stack size of 1MB, the stack
      overflows at a depth of 216 template instantiations, well before the 256
      default limit. This patch modifies the default MSVC stack size to 2MB.
      
      Patch by Yaron Keren!
      
      llvm-svn: 192904
      fd541f00
    • Bill Wendling's avatar
      Add testcase to make sure we don't generate a compact unwind section for ELF binaries. · 16754ddc
      Bill Wendling authored
      This tests r190354.
      
      llvm-svn: 192903
      16754ddc
    • Hans Wennborg's avatar
      clang-cl: Add support for asm listings (/FA and /Fa) · 2c21f74f
      Hans Wennborg authored
      This adds support for outputing the assembly to a file during compilation.
      It does this by changing the compilation pipeling to not use the integrated
      assembler, and keep the intermediate assembler file.
      
      Differential Revision: http://llvm-reviews.chandlerc.com/D1946
      
      llvm-svn: 192902
      2c21f74f
    • Alexander Potapenko's avatar
    • Rafael Espindola's avatar
      Rename some functions for consistency. · 8db352d5
      Rafael Espindola authored
      Every other function in Redeclarable.h was using Decl instead of Declaration.
      
      llvm-svn: 192900
      8db352d5
    • Daniel Sanders's avatar
      [mips] Added -mfp64 and -mfp32 options. · 94694170
      Daniel Sanders authored
      These options specify 64-bit FP registers and 32-bit FP registers respectively.
      
      When using -mfp32, the FPU has 16x double-precision registers overlapping with
      the 32x single-precision registers (each double-precision register overlaps
      two single-precision registers).
      
      When using -mfp64, the FPU has 32x double-precision registers overlapping with
      the 32x single-precision registers (each double-precision register overlaps
      with one single-precision register and has an additional 32-bits).
      
      MSA requires -mfp64.
      
      llvm-svn: 192899
      94694170
    • Daniel Sanders's avatar
      [mips][msa] Update -mmsa help text and removed the hidden flag to better match... · 206bf624
      Daniel Sanders authored
      [mips][msa] Update -mmsa help text and removed the hidden flag to better match conventions used by other targets
      
      llvm-svn: 192898
      206bf624
Loading