Skip to content
  • Marshall Clow's avatar
    Change the control flow in atomic_compare_exchange_strong to avoid a potential deadlock. · 3379baeb
    Marshall Clow authored
    When you assign a shared_ptr, the deleter gets called and assigned. In this routine, the assignment happens inside a critical section, which could (potentially) lead to a deadlock, if the deleter did something wonky. Now we swap the old value with an (empty) temporary shared_ptr, and then let the temporary delete the old value when it goes out of scope (after the lock has been released).  This should fix PR#27724. Thanks to Hans Boehm for the bug report and the suggested fix.
    
    llvm-svn: 269965
    3379baeb
Loading