Skip to content
  • George Rimar's avatar
    [llvm-readobj/libObject] - Introduce a custom warning handler for `ELFFile<ELFT>` methods. · 67ea32a0
    George Rimar authored
    Currently, we have a code duplication in llvm-readobj which was introduced in D63266.
    The duplication was introduced to allow llvm-readobj to dump the partially
    broken object. Methods in ELFFile<ELFT> perform a strict validation of the inputs,
    what is itself good, but not for dumper tools, that might want to dump the information,
    even if some pieces are broken/unexpected.
    
    This patch introduces a warning handler which can be passed to ELFFile<ELFT> methods
    and can allow skipping the non-critical errors when needed/possible.
    
    For demonstration, I removed the duplication from llvm-readobj and implemented a warning using
    the new custom warning handler. It also deduplicates the strings printed, making the output less verbose.
    
    Differential revision: https://reviews.llvm.org/D65515
    
    llvm-svn: 368260
    67ea32a0
Loading