Skip to content
  • Rui Ueyama's avatar
    COFF: Fix ICF correctness bug. · 871847e3
    Rui Ueyama authored
    When comparing two COMDAT sections, we need to take section values
    and associative sections into account. This patch fixes that bug.
    It fixes a crash bug of llvm-tblgen when linked with /opt:lldicf.
    
    One thing I don't understand yet is that this logic seems to be
    too strict. MSVC linker is able to create more compact executables
    (which of course work correctly). With this ICF algorithm, LLD is
    able to make executable smaller, but the outputs are larger than
    MSVC's. There must be something I'm missing here.
    
    llvm-svn: 240897
    871847e3
Loading