Skip to content
  • Zachary Turner's avatar
    [lit] Force site configs to be run before source-tree configs · a0e55b64
    Zachary Turner authored
    This patch simplifies LLVM's lit infrastructure by enforcing an ordering
    that a site config is always run before a source-tree config.
    
    A significant amount of the complexity from lit config files arises from
    the fact that inside of a source-tree config file, we don't yet know if
    the site config has been run.  However it is *always* required to run
    a site config first, because it passes various variables down through
    CMake that the main config depends on.  As a result, every config
    file has to do a bunch of magic to try to reverse-engineer the location
    of the site config file if they detect (heuristically) that the site
    config file has not yet been run.
    
    This patch solves the problem by emitting a mapping from source tree
    config file to binary tree site config file in llvm-lit.py. Then, during
    discovery when we find a config file, we check to see if we have a
    target mapping for it, and if so we use that instead.
    
    This mechanism is generic enough that it does not affect external users
    of lit. They will just not have a config mapping defined, and everything
    will work as normal.
    
    On the other hand, for us it allows us to make many simplifications:
    
    * We are guaranteed that a site config will be executed first
    * Inside of a main config, we no longer have to assume that attributes
      might not be present and use getattr everywhere.
    * We no longer have to pass parameters such as --param llvm_site_config=<path>
      on the command line.
    * It is future-proof, meaning you don't have to edit llvm-lit.in to add
      support for new projects.
    * All of the duplicated logic of trying various fallback mechanisms of
      finding a site config from the main config are now gone.
    
    One potentially noteworthy thing that was required to implement this
    change is that whereas the ninja check targets previously used the first
    method to spawn lit, they now use the second. In particular, you can no
    longer run lit.py against the source tree while specifying the various
    `foo_site_config=<path>` parameters.  Instead, you need to run
    llvm-lit.py.
    
    Differential Revision: https://reviews.llvm.org/D37756
    
    llvm-svn: 313270
    a0e55b64
Loading