[ArgPromote] Replace all the grep-based testing with precise FileCheck

tests.

This also removes the use of instcombine as we can max the patterns
produced by argument promotion directly with the more powerful tools in
FileCheck.

llvm-svn: 294174