[GlobalISel] Introduce G_CONSTANT_FOLD_BARRIER and use it to prevent constant folding
hoisted constants. The constant hoisting pass tries to hoist large constants into predecessors and also generates remat instructions in terms of the hoisted constants. These aim to prevent codegen from rematerializing expensive constants multiple times. So we can re-use this optimization, we can preserve the no-op bitcasts that are used to anchor constants to the predecessor blocks. SelectionDAG achieves this by having the OpaqueConstant node, which is just a normal constant with an opaque flag set. I've opted to avoid introducing a new constant generic instruction here. Instead, we have a new G_CONSTANT_FOLD_BARRIER operation that constitutes a folding barrier. These are somewhat like the optimization hints, G_ASSERT_ZEXT in that they're eliminated by the generic instruction selection code. This change by itself has very minor improvements in -Os CTMark overall. What this does allow is better optimizations when future combines are added that rely on having expensive constants remain unfolded. Differential Revision: https://reviews.llvm.org/D144336
Loading
Please sign in to comment