Call WatchpointList::RemoveAll in Target::Destroy.
I noticed that the test TestSetWatchpoint.py was failing every so often on macOS. The failure was in the last assert, that after destroying the SBTarget containing it, the SBWatchpoint was still saying it was valid. IsValid in this case just meant the watchpoint weak pointer could be turned into a shared pointer. The watchpoint shared pointers have two strong references in general, one to the "Target::m_last_created_watchpoint", and one in the Target::m_watchpoint_list. Target::Destroy reset the last created watchpoint but neglected to call RemoveAll on the watchpoint list (it does the analogous work for the internal & external breakpoint lists...) This patch does the equivalent cleanup for the watchpoint list.
Loading
Please sign in to comment