[AMDGPU] Fix 64 bit DPP validation
AMDGPUAsmParser::isSupportedDPPCtrl() was failing to correctly find a DPP register operand, regadless of the position it is always src0. Moved this check into a new validateDPP() method where we have full instruction already. In particular it was failing to reject this case: v_cvt_u32_f64 v5, v[0:1] quad_perm:[0,2,1,1] row_mask:0xf bank_mask:0xf Essentially it was broken for any case where size of dst and src0 differ. It also improves the diagnostics with a proper error message. The check in the InstPrinter also drops verification of the dst register as it does not have anything to do with the dpp operand. Differential Revision: https://reviews.llvm.org/D101930
Loading
Please sign in to comment