Skip to content
Commit 2abf997f authored by Med Ismail Bennani's avatar Med Ismail Bennani
Browse files

[lldb] Fix assertions caused by un-checked errors in ScriptedProcess



This patch should fix some assertion that started getting hit after f22d82ce.

That commit changed the scripted object plugin creation to use
`llvm::Expected<T>` as a return type to enforce error handling, however
I forgot to handle the error which caused the assert.

The interesting  part about this, is that since that assert was triggered
in the ScriptedProcess constructor (where the `llvm::Error` wasn't
handled), that impacted every test that launched any kind of process,
since the process plugin manager would eventually also iterate over the
`ScriptedProcess::Create` factory method.

This patch should fix the assertions by handling the errors.

Signed-off-by: default avatarMed Ismail Bennani <ismail@bennani.ma>
parent a3e5c947
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment