[llvm][MC] Remove [[nodiscard]] from WithMarkup constructor

This is causing a lot of warnings with older compilers and
errors for -Werror builders downstream.

I'm removing it until we can decide a good way to do this,
as it does seem important that this class not be discarded
given it controls formatting.