[libc++][format] Removes test redundancy.
The format function test serve two purposes: - Test whether all format functions work in general. - Test whether all formatting rules are implemented correctly. At the moment the *pass.cpp tests do both. These tests are quite slow, while testing all rules for all functions doesn't add much coverage. There are two execution modi of the format functions: - run-time validation in the vformat functions. - compile-time validation in the other function. So instead of running all tests for all functions, they are only used for format.pass.cpp and vformat.pass.cpp still do all tests. The other tests do a smaller set of test, just to make sure they work in the basics. Running the format tests using one thread: - before 00:04:16 - after 00:02:14 The slow tests were also reported in https::llvm.org/PR58141 Also split a generic part of the test to a generic support header. This allows these parts to be reused in the range-based formatter tests. Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D140115
Loading
Please sign in to comment