More constant evaluation cleanup, and fix an issue where we'd override an

earlier 'non-constant' diagnostic with a later one if the earlier one was from
a side-effect we thought we could evaluate past.

llvm-svn: 194117