[DAGCombine] Use `IsKnownNeverZero` to see if we need zero-check in is_pow2 setcc patern
`ctpop(X) eq/ne 1` is checking if X is a non-zero power of 2. Power of 2 check including zero is `(X & (X-1)) eq/ne 0` and unfortunately there is no good pattern for checking a power of 2 while excluding zero. So, when lowering `ctpop(X) eq/ne 1`, explicitly check `IsKnownNeverZero(X)` to maybe be able to optimize out the extra zero check. We need this explicitly as DAGCombiner does not re-analyze provable setcc nodes, and the middle-end never finds it beneficially to broaden `ctpop(X) eq/ne 1` -> `ctpop(X) ule/ugt 1` (power of 2 including zero). Reviewed By: RKSimon Differential Revision: https://reviews.llvm.org/D152675
Loading
Please sign in to comment