[SROA] More range-based cleanups to SROA, these brought to you by

clang-modernize.

I did have to clean up the variable types and whitespace a bit because
the use of auto made the code much less readable here.

llvm-svn: 219962