[Support] [Windows] Don't cancel delete if we failed to set delete
Following up on commit 177176f7, if we failed to setDeleteDisposition(true) during TempFile creation, then don't try to setDeleteDisposition(false) during TempFile::keep, since it will likely fail as well. Instead of letting TempFile::keep just fail, we should let it go ahead and try renaming the file. This fixes an issue we are seeing when running clang-cl.exe through the Incredibuild distributed build system. We're seeing that renaming temporary object files would fail here: https://github.com/llvm/llvm-project/blob/5c1f7b296ac0dddeca02891976e6ab5cfc006719/clang/lib/Frontend/CompilerInstance.cpp#L789 Reviewed By: mstorsjo Differential Revision: https://reviews.llvm.org/D118212
Loading
Please sign in to comment