[JITLink] Process null symbols
Some relocations (e.g., R_RISCV_ALIGN) don't have a target symbol and use a null symbol as a placeholder. These symbols were not processed before making it impossible to create edges for them. This patch tries to detect these null symbols and create absolute symbols for them. Note that technically, these null symbols are UND in the ELF file, not ABS, so it might make more consistent to create a new symbol type for this (local undefined or so). However, since these symbols are only used as placeholders (i.e., their values are never used), I don't think it's worth the effort of doing this. Also note that in the binaries that I have inspected, this null symbol always has index 0. Could it make sense to add that to the test to avoid accidentally adding unnecessary symbols? The reason I didn't do this yet, is that I couldn't find any references in the specs that actually guarantee this. Reviewed By: lhames Differential Revision: https://reviews.llvm.org/D149541
Loading
Please sign in to comment