[Sema] Improve notes for value category mismatch in overloading
When an overloaded member function has a ref-qualifier, like: class X { void f() &&; void f(int) &; }; we would print strange notes when the ref-qualifier doesn't fit the value category: X x; x.f(); X().f(0); would both print a note "no known conversion from 'X' to 'X' for object argument" on their relevant overload instead of pointing out the mismatch in value category. At first I thought the solution is easy: just use the FailureKind member of the BadConversionSequence struct. But it turns out that we weren't properly setting this for function arguments. So I went through TryReferenceInit to make sure we're doing that right, and found a number of notes in the existing tests that improved as well. Fixes PR47791. Reviewed By: rsmith Differential Revision: https://reviews.llvm.org/D90123
Loading
Please sign in to comment