[llvm-readobj] Standardize JSON output for `Other` field
Today, the LLVM output uses special handling when the Other field is 0. This output makes sense for a command line utility that a human will read, but JSON is a machine readable format, so being consistent is more important. Prior to this change, any consumer of the JSON output would need to handle the Other field specially, since the structure of the JSON would no longer be consistent. Changes to JSON output when Other flag == 0: ``` "Other": 0, -> "Other": { "RawFlags": 0, "Flags": [] }, ``` There are no changes to when Other flag != 0: ``` "Other": { -> "Other": { "RawFlags": 1, "RawFlags": 1, "Flags": [ "Flags": [ ... ... ] ] }, }, ``` This patch adds a overload for the JSONELFDumper's printSymbol() method, that uses consistent output formatting, regardless of the value of the Other field. Depends on D137092 Reviewed By: jhenderson Differential Revision: https://reviews.llvm.org/D137088
Loading
Please sign in to comment