[clang-tidy] Make ClangTidyOptionsProvider::getOptions return by value.

Returning by reference limits possible implementations and doesn't bring any
benefits as all callers make copies of the returned value anyway.

llvm-svn: 226553