[lldb/Target] Initialize new targets environment variables from target.env-vars
Summary: The TargetProperties constructor invokes a series of callbacks to prime the properties from the default ones. The one callback in charge of updating the inferior environment was commented out because it crashed. The reason for the crash is that TargetProperties is a parent class of Target and the callbacks were invoked using a Target that was not fully initialized. This patch moves the initial callback invocations to a separate function that can be called at the end the Target constructor, thus preventing the crash. One existing test had to be modified, because the initialization of the environment properties now take place at the time the target is created, not at the first use of the environment (usually launch time). The added test checks that the LaunchInfo object returned by the target has been primed with the values from the settings. Reviewers: jingham, labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D76009
Loading
Please sign in to comment