Skip to content
Commit 9d9c25f8 authored by Chuanqi Xu's avatar Chuanqi Xu
Browse files

[C++20] [Coroutines] Don't mark await_suspend as noinline if it is specified...

[C++20] [Coroutines] Don't mark await_suspend as noinline if it is specified as always_inline already

Address https://github.com/llvm/llvm-project/issues/64933 and partially
https://github.com/llvm/llvm-project/issues/64945.

After c4672454, we will add a noinline attribute to the await_suspend
member function of an awaiter if the awaiter has any non static member
functions.

Obviously, this decision will bring some performance regressions. And
people may complain about this while the long term solution may not be
available soon. In such cases, it is better to provide a solution for
the users who met the regression surprisingly.

Also it is natural to not prevent the inlining if the function is marked
as always_inline by the users already.
parent 57aee4ea
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment