[clang-format] Minimize the damage caused by AlignArrayOfStructures when...
[clang-format] Minimize the damage caused by AlignArrayOfStructures when working on non square arrays I have lost count of the number of times this has been reported, but it fundamentally comes down to the fact that the "AlignArrayLeft/Right" function is fundamentally broken for non-square arrays. As a result, a pointer can end up running off the end of the array structure, I've spent the last 2 weekends trying to rewrite this algorithm but I've struggled to get it aligned correctly. This is an interim fix, that ignores all array that are non-square and leaves them alone. I think this can allow us to close out most of the crashes (if not all). I think this can help reduce the number of bugs coming in that are duplicates. https://github.com/llvm/llvm-project/issues/53748 https://github.com/llvm/llvm-project/issues/51767 https://github.com/llvm/llvm-project/issues/51277 Reviewed By: curdeius, HazardyKnusperkeks, feg208 Differential Revision: https://reviews.llvm.org/D121069
Loading
Please sign in to comment