[lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE
This function does a _lot_ of different things: 1. Parses a DIE, 2. Builds an ExpressionList 3. Figures out lifetime of variable 4. Remaps addresses for debug maps 5. Handles external variables 6. Figures out scope of variables A lot of this functionality is coded in a complex nest of conditions, variables that are declared and then initialized much later, variables that are updated in multiple code paths. All of this makes the code really hard to follow. This commit attempts to improve the state of things by factoring out (3), adding documentation on how the expression list is built, and by reducing the scope of variables. Differential Revision: https://reviews.llvm.org/D154513
Loading
Please sign in to comment