Skip to content
  1. Jun 19, 2012
  2. Jun 18, 2012
  3. Jun 17, 2012
    • NAKAMURA Takumi's avatar
      TableGen.cmake: Fix to work without LLVM_COMMON_DEPENDS. · e0d4a7c5
      NAKAMURA Takumi authored
      llvm-svn: 158650
      e0d4a7c5
    • Benjamin Kramer's avatar
    • Benjamin Kramer's avatar
      Add missing unittest files to the cmake build. · 6bc197e4
      Benjamin Kramer authored
      llvm-svn: 158647
      6bc197e4
    • Benjamin Kramer's avatar
      Remove SmallMap unittests, unbreaking the build. · ae7f7937
      Benjamin Kramer authored
      I don't know how useful these are for SmallDenseMap, I'll leave that decision to Chandler.
      
      llvm-svn: 158646
      ae7f7937
    • Benjamin Kramer's avatar
      Bring the return value of SmallVector::insert in line with std::vector::insert. · 23a9c3e0
      Benjamin Kramer authored
      It always returns the iterator for the first inserted element, or the passed in
      iterator if the inserted range was empty. Flesh out the unit test more and fix
      all the cases it uncovered so far.
      
      llvm-svn: 158645
      23a9c3e0
    • Chandler Carruth's avatar
      Remove SmallMap, and the several files that were used to implement it. · b539b477
      Chandler Carruth authored
      We have SmallDenseMap now that has more correct and predictable
      semantics, even though it is a more narrow abstraction.
      
      llvm-svn: 158644
      b539b477
    • Benjamin Kramer's avatar
      SmallVector: return a valid iterator for the rare case of inserting an empty... · 371b9b0e
      Benjamin Kramer authored
      SmallVector: return a valid iterator for the rare case of inserting an empty range into a SmallVector.
      
      Patch by Johannes Schaub!
      
      llvm-svn: 158643
      371b9b0e
    • Chandler Carruth's avatar
      Add a unit test for 'swap', and fix a pile of bugs in · 4de807a5
      Chandler Carruth authored
      SmallDenseMap::swap.
      
      First, make it parse cleanly. Yay for uninstantiated methods.
      
      Second, make the inline-buckets case work correctly. This is way
      trickier than it should be due to the uninitialized values in empty and
      tombstone buckets.
      
      Finally fix a few typos that caused construction/destruction mismatches
      in the counting unittest.
      
      llvm-svn: 158641
      4de807a5
    • Chandler Carruth's avatar
      Disable a particular assertion on MSVC... I'm deeply disturbed by its · d599a8c4
      Chandler Carruth authored
      implementation of the class layout for the V8 type.
      
      llvm-svn: 158640
      d599a8c4
    • Chandler Carruth's avatar
      Add tests for *DenesMap for both key and value types' construction and · a1be842f
      Chandler Carruth authored
      destruction and fix a bug in SmallDenseMap they caught.
      
      This is kind of a poor-man's version of the testing that just adds the
      addresses to a set on construction and removes them on destruction. We
      check that double construction and double destruction don't occur.
      Amusingly enough, this is enough to catch a lot of SmallDenseMap issues
      because we spend a lot of time with fixed stable addresses in the inline
      buffer.
      
      The SmallDenseMap bug fix included makes grow() not double-destroy in
      some cases. It also fixes a FIXME there, the code was pretty crappy. We
      now don't have any wasted initialization, but we do move the entries in
      inline bucket array an extra time. It's probably a better tradeoff, and
      is much easier to get correct.
      
      llvm-svn: 158639
      a1be842f
    • Chandler Carruth's avatar
      Introduce a SmallDenseMap container that re-uses the existing DenseMap · 20dd838a
      Chandler Carruth authored
      implementation.
      
      This type includes an inline bucket array which is used initially. Once
      it is exceeded, an array of 64 buckets is allocated on the heap. The
      bucket count grows from there as needed. Some highlights of this
      implementation:
      
      - The inline buffer is very carefully aligned, and so supports types
        with alignment constraints.
      - It works hard to avoid aliasing issues.
      - Supports types with non-trivial constructors, destructors, copy
        constructions, etc. It works reasonably hard to minimize copies and
        unnecessary initialization. The most common initialization is to set
        keys to the empty key, and so that should be fast if at all possible.
      
      This class has a performance / space trade-off. It tries to optimize for
      relatively small maps, and so packs the inline bucket array densely into
      the object. It will be marginally slower than a normal DenseMap in a few
      use patterns, so it isn't appropriate everywhere.
      
      The unit tests for DenseMap have been generalized a bit to support
      running over different map implementations in addition to different
      key/value types. They've then been automatically extended to cover the
      new container through the magic of GoogleTest's typed tests.
      
      All of this is still a bit rough though. I'm going to be cleaning up
      some aspects of the implementation, documenting things better, and
      adding tests which include non-trivial types. As soon as I'm comfortable
      with the correctness, I plan to switch existing users of SmallMap over
      to this class as it is already more correct w.r.t. construction and
      destruction of objects iin the map.
      
      Thanks to Benjamin Kramer for all the reviews of this and the lead-up
      patches. That said, more review on this would really be appreciated. As
      I've noted a few times, I'm quite surprised how hard it is to get the
      semantics for a hashtable-based map container with a small buffer
      optimization correct. =]
      
      llvm-svn: 158638
      20dd838a
    • Chandler Carruth's avatar
      Add some somewhat exhaustive tests of sizeof properties of this horrible · a4d40753
      Chandler Carruth authored
      construct just for my sanity.
      
      llvm-svn: 158637
      a4d40753
    • Pete Cooper's avatar
      Now that SROA can form alloca's for dynamic vector accesses, further improve... · 33ee6c9b
      Pete Cooper authored
      Now that SROA can form alloca's for dynamic vector accesses, further improve it to be able to replace operations on these vector alloca's with insert/extract element insts
      
      llvm-svn: 158623
      33ee6c9b
  4. Jun 16, 2012
Loading