[lldb] Remove a wrong assert in TestStructTypes that checks that empty structs...
[lldb] Remove a wrong assert in TestStructTypes that checks that empty structs in C always have size 0 D105471 fixes the way we assign sizes to empty structs in C mode. Instead of just giving them a size 0, we instead use the size we get from DWARF if possible. After landing D105471 the TestStructTypes test started failing on Windows. The tests checked that the size of an empty C struct is 0 while the size LLDB now reports is 4 bytes. It turns out that 4 bytes are the actual size Clang is using for C structs with the MicrosoftRecordLayoutBuilder. The commit that introduced that behaviour is 00a061dc. This patch removes that specific check from TestStructTypes. Note that D105471 added a series of tests that already cover this case (and the added checks automatically adjust to whatever size the target compiler chooses for empty structs).
Loading
Please sign in to comment