Commits · 4a7c8e7aa2e9845652703141b240f9179f1f9980 · Lorenzo Albano / LLVM bpEVL

Jan 19, 2018

Split MachineLICM into EarlyMachineLICM and MachineLICM; NFC · 4a7c8e7a

Matthias Braun authored Jan 19, 2018

This avoids playing games with pseudo pass IDs and avoids using an
unreliable MRI::isSSA() check to determine whether register allocation
has happened.

Note that this renames:
- MachineLICMID -> EarlyMachineLICM
- PostRAMachineLICMID -> MachineLICMID
to be consistent with the EarlyTailDuplicate/TailDuplicate naming.

llvm-svn: 322927

4a7c8e7a

Split TailDuplicatePass into pre- and post-RA variant; NFC · 3ab9fcb9

Matthias Braun authored Jan 19, 2018

Split TailDuplicatePass into EarlyTailDuplicate and TailDuplicate. This
avoids playing games with fake pass IDs and using MRI::isSSA() to
determine pre-/post-RA state.

llvm-svn: 322926

3ab9fcb9

Move tests to the correct place · 8bb5228d

Matthias Braun authored Jan 19, 2018

test/CodeGen/MIR is for testing the MIR parser/printer. Tests for passes
and targets belong to test/CodeGen/TARGETNAME.

llvm-svn: 322925

8bb5228d

[X86] Make better use of instregex for cmovcc/setcc/jcc instructions in the Intel scheduler models. · f4cd9083
Craig Topper authored Jan 19, 2018
```
Combine all the separate condition codes into a singular expression when possible.

llvm-svn: 322924
```
f4cd9083
Revert [CGP] Re-enable Select in complex addressing mode · 22bb1c0e
Serguei Katkov authored Jan 19, 2018
```
One of buildbots failed. Revert for now till fix the issue.

llvm-svn: 322923
```
22bb1c0e

[Fuchsia] Tests for the Fuzzer support in Fuchsia driver · d3b520f6

Petr Hosek authored Jan 19, 2018

This adds driver tests for the Fuzzer support.

Differential Revision: https://reviews.llvm.org/D42283

llvm-svn: 322922

d3b520f6

[WebAssembly] Fix variable whose name is also a type name · 811236c3
Sam Clegg authored Jan 19, 2018
```
Some compilers don't like this and generate a warning.

llvm-svn: 322921
```
811236c3
Wrote my own version of is_permutation; that was dominating the timings · c6b908d0
Marshall Clow authored Jan 19, 2018
```
llvm-svn: 322920
```
c6b908d0

AArch64: Fix emergency spillslot being out of reach for large callframes · 5c290dc2

Matthias Braun authored Jan 19, 2018

Re-commit of r322200: The testcase shouldn't hit machineverifiers
anymore with r322917 in place.

Large callframes (calls with several hundreds or thousands or
parameters) could lead to situations in which the emergency spillslot is
out of range to be addressed relative to the stack pointer.
This commit forces the use of a frame pointer in the presence of large
callframes.

This commit does several things:
- Compute max callframe size at the end of instruction selection.
- Add mirFileLoaded target callback. Use it to compute the max callframe size
  after loading a .mir file when the size wasn't specified in the file.
- Let TargetFrameLowering::hasFP() return true if there exists a
  callframe > 255 bytes.
- Always place the emergency spillslot close to FP if we have a frame
  pointer.
- Note that `useFPForScavengingIndex()` would previously return false
  when a base pointer was available leading to the emergency spillslot
  getting allocated late (that's the whole effect of this callback).
  Which made no sense to me so I took this case out: Even though the
  emergency spillslot is technically not referenced by FP in this case
  we still want it allocated early.

Differential Revision: https://reviews.llvm.org/D40876

llvm-svn: 322919

5c290dc2

[Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC · 702ffea1
Hongbin Zheng authored Jan 19, 2018
```
Differential revision: https://reviews.llvm.org/D42227

llvm-svn: 322918
```
702ffea1

AArch64: Omit callframe setup/destroy when not necessary · dc4b3e87

Matthias Braun authored Jan 19, 2018

Do not create CALLSEQ_START/CALLSEQ_END when there is no callframe to
setup and the callframe size is 0.

- Fixes an invalid callframe nesting for byval arguments, which would
  look like this before this patch (as in `big-byval.ll`):
    ...
    ADJCALLSTACKDOWN 32768, 0, ...   # Setup for extfunc
    ...
    ADJCALLSTACKDOWN 0, 0, ...  # setup for memcpy
    ...
    BL &memcpy ...
    ADJCALLSTACKUP 0, 0, ...    # destroy for memcpy
    ...
    BL &extfunc
    ADJCALLSTACKUP 32768, 0, ...   # destroy for extfunc

- Saves us two instructions in the common case of zero-sized stackframes.
- Remove an unnecessary scheduling barrier (hence the small unittest
  changes).

Differential Revision: https://reviews.llvm.org/D42006

llvm-svn: 322917

dc4b3e87

[Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia · 34230844

Petr Hosek authored Jan 19, 2018

libFuzzer has been ported to Fuchsia so enable it in the driver.

Differential Revision: https://reviews.llvm.org/D42275

llvm-svn: 322916

34230844

[WebAssembly] Add test expectations for gcc C++ tests (gcc/testsuite/g++.dg) · b6c5bc27
Sam Clegg authored Jan 19, 2018
```
Differential Revision: https://reviews.llvm.org/D42226

llvm-svn: 322915
```
b6c5bc27
[ORC] Revert r322913 while I investigate an ASan failure. · 44efd042
Lang Hames authored Jan 19, 2018
```
llvm-svn: 322914
```
44efd042

[ORC] Redesign the JITSymbolResolver interface to support bulk queries. · 817df9fa

Lang Hames authored Jan 19, 2018

Bulk queries reduce IPC/RPC overhead for cross-process JITing and expose
opportunities for parallel compilation.

The two new query methods are lookupFlags, which finds the flags for each of a
set of symbols; and lookup, which finds the address and flags for each of a
set of symbols. (See doxygen comments for more details.)

The existing JITSymbolResolver class is renamed LegacyJITSymbolResolver, and
modified to extend the new JITSymbolResolver class using the following scheme:

- lookupFlags is implemented by calling findSymbolInLogicalDylib for each of the
symbols, then returning the result of calling getFlags() on each of these
symbols. (Importantly: lookupFlags does NOT call getAddress on the returned
symbols, so lookupFlags will never trigger materialization, and lookupFlags will
never call findSymbol, so only symbols that are part of the logical dylib will
return results.)

- lookup is implemented by calling findSymbolInLogicalDylib for each symbol and
falling back to findSymbol if findSymbolInLogicalDylib returns a null result.
Assuming a symbol is found its getAddress method is called to materialize it and
the result (if getAddress succeeds) is stored in the result map, or the error
(if getAddress fails) is returned immediately from lookup. If any symbol is not
found then lookup returns immediately with an error.

This change will break any out-of-tree derivatives of JITSymbolResolver. This
can be fixed by updating those classes to derive from LegacyJITSymbolResolver
instead.

llvm-svn: 322913

817df9fa

[X86] Add missing check for RDSEED to ICL, CNL, SKX sections of... · c0b4aba7

Craig Topper authored Jan 19, 2018

[X86] Add missing check for RDSEED to ICL, CNL, SKX sections of test/Preprocessor/predefined-arch-macros.c

llvm-svn: 322912

c0b4aba7

[WebAssembly] Export the stack pointer when using --emit-relocs · 14ae6e7c

Sam Clegg authored Jan 18, 2018

This solves the problem that --emit-relocs needs the stack-pointer
to be exported, in order to write out any relocations that reference
the __stack_pointer symbol by its symbol index.

Patch by Nicholas Wilson!

Differential Revision: https://reviews.llvm.org/D42237

llvm-svn: 322911

14ae6e7c

[X86] Add intrinsic support for the RDPID instruction · 84b26b90

Craig Topper authored Jan 18, 2018

This adds a new instrinsic to support the rdpid instruction. The implementation is a bit weird because the intrinsic is defined as always returning 32-bits, but the assembler support thinks the instruction produces a 64-bit register in 64-bit mode. But really it zeros the upper 32 bits. So I had to add separate patterns where 64-bit mode uses an extract_subreg.

Differential Revision: https://reviews.llvm.org/D42205

llvm-svn: 322910

84b26b90

Add a missing file header. · 4b7cf160
Rui Ueyama authored Jan 18, 2018
```
llvm-svn: 322909
```
4b7cf160

[WebAssembly] Add missing function exports and SYM_INFO to --relocatable output · d3052d55

Sam Clegg authored Jan 18, 2018

When writing relocatable files we were exporting for all globals
(including file-local syms), but not for functions. Oops. To be
consistent with non-relocatable output, all symbols (file-local
and global) should be exported. Any symbol targetted by further
relocations needs to be exported. The lack of local function
exports was just an omission, I think.

Second bug: Local symbol names can collide, causing an illegal
Wasm file to be generated! Oops again. This only previously affected
producing relocatable output from two files, where each had a global
with the same name. We need to "budge" the symbol names for locals
that are exported on relocatable output.

Third bug: LLD's relocatable output wasn't writing out any symbol
flags! Thus the local globals weren't being marked as local, and
the hidden flag was also stripped...

Added tests to exercise colliding local names with/without
relocatable flag

Patch by Nicholas Wilson!

Differential Revision: https://reviews.llvm.org/D42105

llvm-svn: 322908

d3052d55

[InstSimplify] regenerate checks and add tests for commutes; NFC · a19b748f
Sanjay Patel authored Jan 18, 2018
```
llvm-svn: 322907
```
a19b748f

Jan 18, 2018

AMDGPU/SI: Fix typos in d16 support patch the buffer intrinsics. · ba6240cc
Changpeng Fang authored Jan 18, 2018
```
llvm-svn: 322906
```
ba6240cc

[CodeView] Add line numbers for inlined call sites · 7897a789

Reid Kleckner authored Jan 18, 2018

We did this for inline call site line tables, but we hadn't done it for
regular function line tables yet. This patch copies that logic from
encodeInlineLineTable.

llvm-svn: 322905

7897a789

[CodeView] Sink complex inline functions to .cpp file, NFC · b5258722
Reid Kleckner authored Jan 18, 2018
```
I'm cleaning up this code before I attempt to fix a line table bug.

llvm-svn: 322904
```
b5258722

AMDGPU/SI: Add d16 support for image intrinsics. · 4737e892

Changpeng Fang authored Jan 18, 2018

Summary:
  This patch implements d16 support for image load, image store and image sample intrinsics.

Reviewers:
  Matt, Brian.

Differential Revision:
  https://reviews.llvm.org/D3991

llvm-svn: 322903

4737e892

Typo fix SIBABRT -> SIGABRT. · 668e6b4b
Eric Christopher authored Jan 18, 2018
```
Based on a patch by Henry Wong!

llvm-svn: 322902
```
668e6b4b

Remove TautologicalInRangeCompare from Extra and TautologicalCompare. · 8c55e211

Nico Weber authored Jan 18, 2018

This removes the following (already default-off) warnings from -Wextra:
  -Wtautological-type-limit-compare,
  -Wtautological-unsigned-zero-compare
  -Wtautological-unsigned-enum-zero-compare

On the thread "[cfe-dev] -Wtautological-constant-compare issues", clang
code owners Richard Smith, John McCall, and Reid Kleckner as well as
libc++ code owner Marshall Clow stated that these new warnings are not
yet ready for prime time and shouldn't be part of -Wextra.

Furthermore, Vedant Kumar (Apple), Peter Hosek (Fuchsia), and me (Chromium)
expressed the same concerns (Vedant on that thread, Peter on
https://reviews.llvm.org/D39462, me on https://reviews.llvm.org/D41512).

So remove them from -Wextra, and remove TautologicalInRangeCompare from
TautologicalCompare too until they're usable with real-world code.

llvm-svn: 322901

8c55e211

[test] Actually check the common parts in CodeGen/ARM/global-merge-external.ll. NFC. · d96be854

Martin Storsjö authored Jan 18, 2018

Previously, these parts weren't ever checked. The label patterns
need to be extended to match successfully on macho.

Differential Revision: https://reviews.llvm.org/D42126

llvm-svn: 322900

d96be854