Skip to content
  1. Nov 07, 2016
    • Jonas Hahnfeld's avatar
      [OpenMP] Enable ThreadSanitizer to check OpenMP programs · 50fed047
      Jonas Hahnfeld authored
      This patch allows ThreadSanitizer (Tsan) to verify OpenMP programs.
      It means that no false positive will be reported by Tsan when
      verifying an OpenMP programs.
      This patch introduces annotations within the OpenMP runtime module to
      provide information about thread synchronization to the Tsan runtime.
      
      In order to enable the Tsan support when building the runtime, you must
      enable the TSAN_SUPPORT option with the following environment variable:
      
      -DLIBOMP_TSAN_SUPPORT=TRUE
      
      The annotations will be enabled in the main shared library
      (same mechanism of OMPT).
      
      Patch by Simone Atzeni and Joachim Protze!
      
      Differential Revision: https://reviews.llvm.org/D13072
      
      llvm-svn: 286115
      50fed047
  2. Jun 28, 2016
    • Jonathan Peyton's avatar
      Fix bugs in TAS and futex lock · ac7ba406
      Jonathan Peyton authored
      * Incorrect lock value written in __kmp_test_futex_lock
      * Incorrect lock value check in tas/futex lock with USE_LOCK_PROFILE on
      
      Patch by Hansang Bae
      
      llvm-svn: 274053
      ac7ba406
  3. May 31, 2016
    • Paul Osmialowski's avatar
      Use C++11 atomics for ticket locks implementation · f7cc6aff
      Paul Osmialowski authored
      This patch replaces use of compiler builtin atomics with
      C++11 atomics for ticket locks implementation. Ticket locks
      are used in critical places of the runtime, e.g. in the tasking
      mechanism.
      
      The main reason this change was introduced is the problem
      with work stealing function on ARM architecture which suffered
      from nasty race condition. It turned out that the root cause of
      the problem lies in the way ticket locks are implemented. Changing
      compiler builtins into C++11 atomics solves the problem.
      
      Two assertions were added into kmp_tasking.c which are useful
      for detecting early symptoms of something wrong going on with
      work stealing, which were among the possible outcomes of the
      race condition.
      
      Differential Revision: http://reviews.llvm.org/D19878
      
      llvm-svn: 271324
      f7cc6aff
  4. May 20, 2016
  5. May 16, 2016
    • Paul Osmialowski's avatar
      Clean all the mess around KMP_USE_FUTEX and kmp_lock.h · fb043fdf
      Paul Osmialowski authored
      KMP_USE_FUTEX preprocessor definition defined in kmp_lock.h is used
      inconsequently throughout LLVM libomp code.
      
      * some .c files that use this define do not include kmp_lock.h file,
        in effect guarded part of code are never compiled
      * some places in code use architecture-depending preprocessor
        logic expressions which effectively disable use of Futex for
        AArch64 architecture, all these places should use
        '#if KMP_USE_FUTEX' instead to avoid any further confusions
      * some places use KMP_HAS_FUTEX which is nowhere defined,
        KMP_USE_FUTEX should be used instead
      
      Differential Revision: http://reviews.llvm.org/D19629
      
      llvm-svn: 269642
      fb043fdf
  6. May 07, 2016
  7. Apr 14, 2016
    • Jonathan Peyton's avatar
      Exponential back off logic for test-and-set lock · 377aa40d
      Jonathan Peyton authored
      This change adds back off logic in the test and set lock for better contended
      lock performance. It uses a simple truncated binary exponential back off
      function. The default back off parameters are tuned for x86.
      
      The main back off logic has a two loop structure where each is controlled by a
      user-level parameter:
      max_backoff - limits the outer loop number of iterations.
          This parameter should be a power of 2.
      min_ticks - the inner spin wait loop number of "ticks" which is system
          dependent and should be tuned for your system if you so choose.
          The "ticks" on x86 correspond to the time stamp counter,
          but on other architectures ticks is a timestamp derived
          from gettimeofday().
      
      The user can modify these via the environment variable:
      KMP_SPIN_BACKOFF_PARAMS=max_backoff[,min_ticks]
      Currently, since the default user lock is a queuing lock,
      one would have to also specify KMP_LOCK_KIND=tas to use the test-and-set locks.
      
      Differential Revision: http://reviews.llvm.org/D19020
      
      llvm-svn: 266329
      377aa40d
  8. Mar 30, 2016
  9. Jan 22, 2016
    • Jonathan Peyton's avatar
      Add missing cleanup code for cached indirect lock pool. · 3bd88d4c
      Jonathan Peyton authored
      This change fixes one issue reported at https://llvm.org/bugs/show_bug.cgi?id=26184
      There was missing cleanup code for the cached indirect lock pool. The change
      will fix the reported case where it tries to initialize a lock after runtime
      cleanup/reinitialization, but it is still possible that the user program runs
      into another problem because most test programs have a call to __kmpc_set_lock
      after cleanup/reinitialization without calling __kmpc_init_lock causing a crash/hang.
      
      llvm-svn: 258528
      3bd88d4c
  10. Jan 05, 2016
  11. Dec 11, 2015
    • Jonathan Peyton's avatar
      Hinted lock (OpenMP 4.5 feature) Updates/Fixes Part 3 · b87b5813
      Jonathan Peyton authored
      This change set includes all changes to make the code conform to the OMP 4.5 specification:
      
      * Removed hint / hinted_init definitions from include/40 files
      * Hint values are powers of 2 to enable composition (4.5 spec)
      * Hinted lock initialization functions were renamed (4.5 spec)
        kmp_init_lock_hinted -> omp_init_lock_with_hint
        kmp_init_nest_lock_hinted -> omp_init_nest_lock_with_hint
      * __kmpc_critical_section_with_hint was added to support a critical section with
        a hint (4.5 spec)
      * __kmp_map_hint_to_lock was added to convert a hint (possibly a composite) to
        an internal lock type
      * kmpc_init_lock_with_hint and kmpc_init_nest_lock_with_hint were added as
        internal entries for the hinted lock initializers. The preivous internal
        functions (__kmp_init*) were moved to kmp_csupport.c and reused in multiple
        places
      * Added the two init functions to dllexports
      * KMP_USE_DYNAMIC_LOCK is turned on if OMP_41_ENABLED is turned on
      
      Differential Revision: http://reviews.llvm.org/D15205
      
      llvm-svn: 255376
      b87b5813
    • Jonathan Peyton's avatar
      Hinted lock (OpenMP 4.5 feature) Updates/Fixes Part 2 · dae13d81
      Jonathan Peyton authored
      * Added a new user TSX lock implementation, RTM, This implementation is a
        light-weight version of the adaptive lock implementation, omitting the
        back-off logic for deciding when to specualte (or not). The fall-back lock is
        still the queuing lock.
      * Changed indirect lock table management. The data for indirect lock management
        was encapsulated in the "kmp_indirect_lock_table_t" type. Also, the lock table
        dimension was changed to 2D (was linear), and each entry is a
        kmp_indirect_lock_t object now (was a pointer to an object).
      * Some clean up in the critical section code
      * Removed the limits of the tuning parameters read from KMP_ADAPTIVE_LOCK_PROPS
      * KMP_USE_DYNAMIC_LOCK=1 also turns on these two switches:
        KMP_USE_TSX, KMP_USE_ADAPTIVE_LOCKS
      
      Differential Revision: http://reviews.llvm.org/D15204
      
      llvm-svn: 255375
      dae13d81
    • Jonathan Peyton's avatar
      Hinted lock (OpenMP 4.5 feature) Updates/Fixes · a03533d3
      Jonathan Peyton authored
      There are going to be two more patches which bring this feature up to date and in line with OpenMP 4.5.
      
      * Renamed jump tables for the lock functions (and some clean up).
      * Renamed some macros to be in KMP_ namespace.
      * Return type of unset functions changed from void to int.
      * Enabled use of _xebgin() et al. intrinsics for accessing TSX instructions.
      
      Differential Revision: http://reviews.llvm.org/D15199
      
      llvm-svn: 255373
      a03533d3
  12. Dec 03, 2015
  13. Oct 16, 2015
    • Jonathan Peyton's avatar
      [OMPT] Add OMPT events for API locking · 0e6d4577
      Jonathan Peyton authored
      This fix implements the following OMPT events for the API locking routines:
      * ompt_event_acquired_lock
      * ompt_event_acquired_nest_lock_first
      * ompt_event_acquired_nest_lock_next
      * ompt_event_init_lock
      * ompt_event_init_nest_lock
      * ompt_event_destroy_lock
      * ompt_event_destroy_nest_lock
      
      For the acquired events the depths of the locks ist required, so a return value
      was added similiar to the return values we already have for the release lock
      routines.
      
      Patch by Tim Cramer
      
      Differential Revision: http://reviews.llvm.org/D13689
      
      llvm-svn: 250526
      0e6d4577
  14. Sep 21, 2015
    • Jonathan Peyton's avatar
      [OMPT] Simplify control variable logic for OMPT · b68a85d1
      Jonathan Peyton authored
      Prior to this change, OMPT had a status flag ompt_status, which could take
      several values. This was due to an earlier OMPT design that had several levels
      of enablement (ready, disabled, tracking state, tracking callbacks). The
      current OMPT design has OMPT support either on or off.
      This revision replaces ompt_status with a boolean flag ompt_enabled, which 
      simplifies the runtime logic for OMPT.
      
      Patch by John Mellor-Crummey
      
      Differential Revision: http://reviews.llvm.org/D12999
      
      llvm-svn: 248189
      b68a85d1
  15. Jun 08, 2015
  16. May 23, 2015
  17. Apr 29, 2015
  18. Apr 02, 2015
  19. Feb 20, 2015
  20. Jan 27, 2015
  21. Jan 13, 2015
  22. Oct 07, 2014
    • Jim Cownie's avatar
      I apologise in advance for the size of this check-in. At Intel we do · 4cc4bb4c
      Jim Cownie authored
      understand that this is not friendly, and are working to change our
      internal code-development to make it easier to make development
      features available more frequently and in finer (more functional)
      chunks. Unfortunately we haven't got that in place yet, and unpicking
      this into multiple separate check-ins would be non-trivial, so please
      bear with me on this one. We should be better in the future.
      
      Apologies over, what do we have here?
      
      GGC 4.9 compatibility
      --------------------
      * We have implemented the new entrypoints used by code compiled by GCC
      4.9 to implement the same functionality in gcc 4.8. Therefore code
      compiled with gcc 4.9 that used to work will continue to do so.
      However, there are some other new entrypoints (associated with task
      cancellation) which are not implemented. Therefore user code compiled
      by gcc 4.9 that uses these new features will not link against the LLVM
      runtime. (It remains unclear how to handle those entrypoints, since
      the GCC interface has potentially unpleasant performance implications
      for join barriers even when cancellation is not used)
      
      --- new parallel entry points ---
      new entry points that aren't OpenMP 4.0 related
      These are implemented fully :-
            GOMP_parallel_loop_dynamic()
            GOMP_parallel_loop_guided()
            GOMP_parallel_loop_runtime()
            GOMP_parallel_loop_static()
            GOMP_parallel_sections()
            GOMP_parallel()
      
      --- cancellation entry points ---
      Currently, these only give a runtime error if OMP_CANCELLATION is true
      because our plain barriers don't check for cancellation while waiting
              GOMP_barrier_cancel()
              GOMP_cancel()
              GOMP_cancellation_point()
              GOMP_loop_end_cancel()
              GOMP_sections_end_cancel()
      
      --- taskgroup entry points ---
      These are implemented fully.
            GOMP_taskgroup_start()
            GOMP_taskgroup_end()
      
      --- target entry points ---
      These are empty (as they are in libgomp)
           GOMP_target()
           GOMP_target_data()
           GOMP_target_end_data()
           GOMP_target_update()
           GOMP_teams()
      
      Improvements in Barriers and Fork/Join
      --------------------------------------
      * Barrier and fork/join code is now in its own file (which makes it
      easier to understand and modify).
      * Wait/release code is now templated and in its own file; suspend/resume code is also templated
      * There's a new, hierarchical, barrier, which exploits the
      cache-hierarchy of the Intel(r) Xeon Phi(tm) coprocessor to improve
      fork/join and barrier performance.
      
      ***BEWARE*** the new source files have *not* been added to the legacy
      Cmake build system. If you want to use that fixes wil be required.
      
      Statistics Collection Code
      --------------------------
      * New code has been added to collect application statistics (if this
      is enabled at library compile time; by default it is not). The
      statistics code itself is generally useful, the lightweight timing
      code uses the X86 rdtsc instruction, so will require changes for other
      architectures.
      The intent of this code is not for users to tune their codes but
      rather 
      1) For timing code-paths inside the runtime
      2) For gathering general properties of OpenMP codes to focus attention
      on which OpenMP features are most used. 
      
      Nested Hot Teams
      ----------------
      * The runtime now maintains more state to reduce the overhead of
      creating and destroying inner parallel teams. This improves the
      performance of code that repeatedly uses nested parallelism with the
      same resource allocation. Set the new KMP_HOT_TEAMS_MAX_LEVEL
      envirable to a depth to enable this (and, of course, OMP_NESTED=true
      to enable nested parallelism at all).
      
      Improved Intel(r) VTune(Tm) Amplifier support
      ---------------------------------------------
      * The runtime provides additional information to Vtune via the
      itt_notify interface to allow it to display better OpenMP specific
      analyses of load-imbalance.
      
      Support for OpenMP Composite Statements
      ---------------------------------------
      * Implement new entrypoints required by some of the OpenMP 4.1
      composite statements.
      
      Improved ifdefs
      ---------------
      * More separation of concepts ("Does this platform do X?") from
      platforms ("Are we compiling for platform Y?"), which should simplify
      future porting.
      
      
      ScaleMP* contribution
      ---------------------
      Stack padding to improve the performance in their environment where
      cross-node coherency is managed at the page level.
      
      Redesign of wait and release code
      ---------------------------------
      The code is simplified and performance improved.
      
      Bug Fixes
      ---------
          *Fixes for Windows multiple processor groups.
          *Fix Fortran module build on Linux: offload attribute added.
          *Fix entry names for distribute-parallel-loop construct to be consistent with the compiler codegen.
          *Fix an inconsistent error message for KMP_PLACE_THREADS environment variable.
      
      llvm-svn: 219214
      4cc4bb4c
  23. Feb 24, 2014
  24. Dec 23, 2013
    • Jim Cownie's avatar
      For your Christmas hacking pleasure. · 181b4bb3
      Jim Cownie authored
      This release use aligns with Intel(r) Composer XE 2013 SP1 Product Update 2 
      
      New features
      * The library can now be built with clang (though wiht some
        limitations since clang does not support 128 bit floats)
      * Support for Vtune analysis of load imbalance
      * Code contribution from Steven Noonan to build the runtime for ARM*
        architecture processors 
      * First implementation of runtime API for OpenMP cancellation
      
      Bug Fixes
      * Fixed hang on Windows (only) when using KMP_BLOCKTIME=0
      
      llvm-svn: 197914
      181b4bb3
  25. Sep 27, 2013
Loading