- May 03, 2023
-
-
Mehdi Amini authored
This is part of an on-going migration to adopt Properties inside MLIR. Differential Revision: https://reviews.llvm.org/D148298
-
Mehdi Amini authored
This is part of an on-going migration to adopt Properties inside MLIR. Differential Revision: https://reviews.llvm.org/D148297
-
Mehdi Amini authored
This is part of an on-going migration to adopt Properties inside MLIR. Differential Revision: https://reviews.llvm.org/D148296
-
Zhouyi Zhou authored
In head comment of CurPPLexer field of class Preprocessor, 'The current top of the stack what we're lexing from' should be 'The current top of the stack that we're lexing from'. Differential Revision: https://reviews.llvm.org/D149709
-
Anshil Gandhi authored
Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D149568
-
Nico Weber authored
This should've been part of 8221c316.
-
Nico Weber authored
This adds all the CodeGen deps all over the place. I ran git show 9cfeba5b > foo2.txt to get the original patch into a text file and then ran #!/usr/bin/env python3 import os in_cmake = False for l in open('foo2.txt'): if l.startswith('+++ b/'): cmake = l[len('+++ b/'):-1] in_cmake = 'CMakeLists.txt' in cmake if not in_cmake: continue prefix = 'llvm/utils/gn/secondary/' gn_file = os.path.join(prefix, os.path.dirname(cmake), 'BUILD.gn') if l.startswith('+ '): add = l[1:].strip() if add == 'CodeGen': try: with open(gn_file) as f: contents = f.read() except: print(f'skipping {gn_file}') continue contents = contents.replace(' deps = [', ' deps = ["//llvm/lib/CodeGen",') with open(gn_file, 'w') as f: f.write(contents) to update all the GN files. (I manually removed the dep on CodeGen that this added to llvm-min-tblgen.) Finally, I ran git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format to fix up the formatting.
-
Nico Weber authored
I ran: git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format
-
Mingming Liu authored
instruction CSE'ed another. - This should be a part of D148877. Before that patch, !prof is not added to known-id-set [1], and turns out unknown types of metadata are dropped in the implementation [2]. - This test is mainly added to make sure there won't be regressions for this kind of pattern. The pattern is observed it in application code; looks like the result of indirect call is used as function arguments initially; after the function is inlined load-after-store CSE opportunity is exposed. [1] https://github.com/llvm/llvm-project/blob/f478721231bdb71ba8f0f6fb21673b9b7f652add/llvm/lib/Transforms/Utils/Local.cpp#L2727-L2741 [2] https://github.com/llvm/llvm-project/blob/ade3c6a6a88ed3a9b06c076406f196da9d3cc1b9/llvm/lib/Transforms/Utils/Local.cpp#L2639 Differential Revision: https://reviews.llvm.org/D149396
-
Mingming Liu authored
Differential Revision: https://reviews.llvm.org/D149390
-
Yeting Kuo authored
Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D149334
-
Alex Langford authored
As far as I can tell, this just computes the filename of the FileSpec, which is already conveniently stored in m_filename. We can use FileSpec::GetFilename() instead. Differential Revision: https://reviews.llvm.org/D149663
-
Alex Langford authored
FileSpec::GetFileNameExtension returns a StringRef. In some cases we are calling it and then storing the result in a local. To prevent cases where we store the StringRef, mutate the Filespec, and then try to use the stored StringRef afterwards, I've audited the callsites and made adjustments to mitigate: Either marking the FileSpec it comes from as const (to avoid mutations) or by not storing the StringRef in a local if it makes sense not to. Differential Revision: https://reviews.llvm.org/D149671
-
Nico Weber authored
Doesn't yet add all the CodeGen deps all over the place.
-
Nico Weber authored
-
Nico Weber authored
Apparently `\b` stopped working with --pickaxe-regex for some reason.
-
Nico Weber authored
-
Nico Weber authored
-
Joseph Huber authored
The `add_libc_test` option allows us to enable both kinds of tests in a single option. However, some tests cannot be made hermetic with the current approach. Such as tests that rely on system utilities or libraries. This patch adds two options `UNIT_TEST_ONLY` and `HERMETIC_TEST_ONLY` to offer more fine-grained control over which version gets built. This makes it explicit which version a test supports and why. Depends on D149662 Reviewed By: sivachandra Differential Revision: https://reviews.llvm.org/D149691
-
Joseph Huber authored
This changes over the string unit tests to the new `add_libc_test` framework. The one test that wasn't changes was the memory utils because it overran the static buffer used for the hermetic test's bump pointer. Depends on D149656 Reviewed By: sivachandra Differential Revision: https://reviews.llvm.org/D149662
-
Joseph Huber authored
Currently we use `assert` as a stand-in for the typical test assertions. This is because these functions exist outside of the base test class so we can't use the typical assertion methods. The presence of these asserts makes it difficult to compile these tests in a standalone format. This patch removes all occurrences. Reviewed By: sivachandra Differential Revision: https://reviews.llvm.org/D149656
-
Muhammad Omair Javaid authored
This patch add or removes XFAIL decorator from various tests which were marked xfail for windows. since 44363f2f various tests have started passing but introduced a couple of new failures. Weight is in favor of new XPasses and I have removed XFail decorator from them. Also some new tests have started failing for which we need to file separate bugs. I have marked them xfail for now and will add the bug id after investigating the issue. Differential Revision: https://reviews.llvm.org/D149235
-
Matt Arsenault authored
If we know one operand is positive for maxnum, or one is negative for minnum, the result will have the same sign.
-
Nico Weber authored
-
Nick Desaulniers authored
This reverts commit c117c2c8. itaniumDemangle calls std::strlen with the results of std::string_view::data() which may not be NUL-terminated. This causes lld/test/wasm/why-extract.s to fail when "expensive checks" are enabled via -DLLVM_ENABLE_EXPENSIVE_CHECKS=ON. See D149675 for further discussion. Back this out until the individual demanglers are converted to use std::string_view.
-
Okwan Kwon authored
A func may not have a body. Differential Revision: https://reviews.llvm.org/D149688
-
Teresa Johnson authored
Now that the runtime tracks the lifetime access density directly, we can use that directly in the threshold checks instead of less accurately computing from other statistics. Differential Revision: https://reviews.llvm.org/D149684
-
- May 02, 2023
-
-
Michael Jones authored
This solves issues caused by the symbols for internal components being marked as hidden. When dynamically linked, the tests of internal components, such as printf_parser_test, fail due to the symbols being unavailable. Reviewed By: sivachandra Differential Revision: https://reviews.llvm.org/D149674
-
Jorge Gorbe Moya authored
This is an optional request, but supporting it makes the experience better when re-launching a big binary that takes significant time to parse: instead of tearing down and re-create the whole session we just need to kill the current process and launch a new one. Some non-obvious comments that might help review this change: * After killing the process, we get an "exited" event for it. Because the process no longer exists some interesting things can occur that manifest as flaky failures if not dealt with: - `EventIsProcessEvent` relies on `SBEvent::GetBroadcasterClass`, which can crash if the broadcaster is no longer there: the event only holds a weak_ptr to its broadcaster, and `GetBroadcasterClass` uses it without checking. Other `EventIs*` functions look at the flavor of the EventData, so I have modified EventIsProcessEvent to do that. - We keep the PID of the old process so we can detect its "exited" event and not terminate the whole session. But sometimes the SBProcess we get from the event won't have a PID, for some reason. * I have factored out the code to launch a process out to a new LaunchProcess function, so it can be used from both `request_launch` and `request_restart`. * The restart_runInTerminal test has the same problem with debug builds as the original runInTerminal test: when attaching to the launcher instance of lldb-vscode it takes a long time to parse its debug info. I have used the same workaround to disable that particular test for debug builds. Differential Revision: https://reviews.llvm.org/D147831
-
Louis Dionne authored
This is an attempt to reduce the insane amount of network we use when uploading Clang binaries to Buildkite for other jobs to use. We think that removing debug information will result in much smaller binaries.
-
Andrzej Warzynski authored
The MLIR SVE integration tests are now enabled in the clang-aarch64-full-2stage buildbot under emulation (QEMU) and one of the sparse integration tests is failing [1]: * Integration/Dialect/SparseTensor/CPU/concatenate_dim_1.mlir That test is failing because we we don't have a LIT substitution to replace: ``` ; RUN: mlir-cpu-runner <command> ``` with ``` ; RUN: <emulator> mlir-cpu-runner <command> ``` clang-aarch64-full-2stage does not support SVE natively and hence all SVE integration tests require emulation. Other SVE tests use `lli` (for which we do have the required substitution) and hence are not affected. This patch simplifies concatenate_dim_1.mlir to always use fixed-width vectorisation. We will re-enable scalable vectorisation once LIT substitutions for `mlir-cpu-runner` are updated. [1] https://lab.llvm.org/buildbot/#/builders/179/builds/6062
-
spupyrev authored
Extending yaml profile format with block hashes, which are used for stale profile matching. To avoid duplication of the code, created a new class with a collection of utilities for computing hashes. Reviewed By: Amir Differential Revision: https://reviews.llvm.org/D144306
-
Alexey Bataev authored
NFC.
-
Matt Arsenault authored
-
Dávid Bolvanský authored
Decrease NumOperands from 32 to 16bits (matches MCInstrDesc) so we can use saved bits to extend Flags (https://reviews.llvm.org/D118118). Reviewed By: barannikov88 Differential Revision: https://reviews.llvm.org/D149445
-
Trevor Morris authored
Add tensor.bitcast operator to bitcast between two tensors of compatible shape and same bit width. This can be use to reinterpret an unsigned integer as a signed integer or vice versa. Reviewed By: rsuderman Differential Revision: https://reviews.llvm.org/D149608
-
Teresa Johnson authored
Removes the 'notcoldandcold' allocation type summary (de)serialization support added in D135714, after realizing that this will never be generated in practice. There are 2 uses of the allocation type keywords in the summary. One is for the individual profiled memprof context summaries, and each context can only be assigned a single type of hotness. The second is in the clone version information produced by the MemProfContextDisambiguation whole program step, and we only create a clone for a specific allocation type. Differential Revision: https://reviews.llvm.org/D149669
-
Vitaly Buka authored
Exposed by the test from 8f966ced.
-
Jonas Devlieghere authored
All indexes passed to GetPropertyAtIndex are constants generated by ablegen. We should never pass an invalid index.
-
Florian Hahn authored
Extra test coverage for D149668.
-