Skip to content
  1. Aug 06, 2013
  2. Aug 05, 2013
  3. Aug 02, 2013
  4. Aug 01, 2013
  5. Jul 31, 2013
    • Eric Christopher's avatar
      Fix crashing on invalid inline asm with matching constraints. · e6656ac8
      Eric Christopher authored
      For a testcase like the following:
      
       typedef unsigned long uint64_t;
      
       typedef struct {
         uint64_t lo;
         uint64_t hi;
       } blob128_t;
      
       void add_128_to_128(const blob128_t *in, blob128_t *res) {
         asm ("PAND %1, %0" : "+Q"(*res) : "Q"(*in));
       }
      
      where we'll fail to allocate the register for the output constraint,
      our matching input constraint will not find a register to match,
      and could try to search past the end of the current operands array.
      
      On the idea that we'd like to attempt to keep compilation going
      to find more errors in the module, change the error cases when
      we're visiting inline asm IR to return immediately and avoid
      trying to create a node in the DAG. This leaves us with only
      a single error message per inline asm instruction, but allows us
      to safely keep going in the general case.
      
      llvm-svn: 187470
      e6656ac8
    • Eric Christopher's avatar
      Reflow this to be easier to read. · 029af150
      Eric Christopher authored
      llvm-svn: 187459
      029af150
  6. Jul 30, 2013
  7. Jul 29, 2013
    • Nico Rieck's avatar
      Use proper section suffix for COFF weak symbols · 7fdaee8f
      Nico Rieck authored
      32-bit symbols have "_" as global prefix, but when forming the name of
      COMDAT sections this prefix is ignored. The current behavior assumes that
      this prefix is always present which is not the case for 64-bit and names
      are truncated.
      
      llvm-svn: 187356
      7fdaee8f
  8. Jul 27, 2013
  9. Jul 26, 2013
  10. Jul 25, 2013
    • Andrew Trick's avatar
      RegAllocGreedy comment. · f4b1ee34
      Andrew Trick authored
      llvm-svn: 187141
      f4b1ee34
    • Andrew Trick's avatar
      Evict local live ranges if they can be reassigned. · 8bb0a251
      Andrew Trick authored
      The previous change to local live range allocation also suppressed
      eviction of local ranges. In rare cases, this could result in more
      expensive register choices. This commit actually revives a feature
      that I added long ago: check if live ranges can be reassigned before
      eviction. But now it only happens in rare cases of evicting a local
      live range because another local live range wants a cheaper register.
      
      The benefit is improved code size for some benchmarks on x86 and armv7.
      
      I measured no significant compile time increase and performance
      changes are noise.
      
      llvm-svn: 187140
      8bb0a251
    • Andrew Trick's avatar
      Allocate local registers in order for optimal coloring. · 8485257d
      Andrew Trick authored
      Also avoid locals evicting locals just because they want a cheaper register.
      
      Problem: MI Sched knows exactly how many registers we have and assumes
      they can be colored. In cases where we have large blocks, usually from
      unrolled loops, greedy coloring fails. This is a source of
      "regressions" from the MI Scheduler on x86. I noticed this issue on
      x86 where we have long chains of two-address defs in the same live
      range. It's easy to see this in matrix multiplication benchmarks like
      IRSmk and even the unit test misched-matmul.ll.
      
      A fundamental difference between the LLVM register allocator and
      conventional graph coloring is that in our model a live range can't
      discover its neighbors, it can only verify its neighbors. That's why
      we initially went for greedy coloring and added eviction to deal with
      the hard cases. However, for singly defined and two-address live
      ranges, we can optimally color without visiting neighbors simply by
      processing the live ranges in instruction order.
      
      Other beneficial side effects:
      
      It is much easier to understand and debug regalloc for large blocks
      when the live ranges are allocated in order. Yes, global allocation is
      still very confusing, but it's nice to be able to comprehend what
      happened locally.
      
      Heuristics could be added to bias register assignment based on
      instruction locality (think late register pairing, banks...).
      
      Intuituvely this will make some test cases that are on the threshold
      of register pressure more stable.
      
      llvm-svn: 187139
      8485257d
    • Adrian Prantl's avatar
      typo. · e4daf52a
      Adrian Prantl authored
      llvm-svn: 187135
      e4daf52a
    • Andrew Trick's avatar
      MI Sched: Register pressure heuristics. · 401b6959
      Andrew Trick authored
      Consider which set is being increased or decreased before comparing.
      
      llvm-svn: 187110
      401b6959
    • Andrew Trick's avatar
    • Andrew Trick's avatar
      Dump LIS before regalloc. MI sched changes them. · 9706496b
      Andrew Trick authored
      llvm-svn: 187107
      9706496b
    • Bill Wendling's avatar
      Replace the "NoFramePointerElimNonLeaf" target option with a function attribute. · 440e9d81
      Bill Wendling authored
      There's no need to specify a flag to omit frame pointer elimination on non-leaf
      nodes...(Honestly, I can't parse that option out.) Use the function attribute
      stuff instead.
      
      llvm-svn: 187093
      440e9d81
  11. Jul 24, 2013
    • Quentin Colombet's avatar
      Fix a bug in IfConverter with nested predicates. · bdab227e
      Quentin Colombet authored
      Prior to this patch, IfConverter may widen the cases where a sequence of
      instructions were executed because of the way it uses nested predicates. This
      result in incorrect execution.
      
      For instance, Let A be a basic block that flows conditionally into B and B be a
      predicated block.
      B can be predicated with A.BrToBPredicate into A iff B.Predicate is less
      "permissive" than A.BrToBPredicate, i.e., iff A.BrToBPredicate subsumes
      B.Predicate.
      
      The IfConverter was checking the opposite: B.Predicate subsumes
      A.BrToBPredicate.
      
      <rdar://problem/14379453>
      
      llvm-svn: 187071
      bdab227e
    • Tom Stellard's avatar
      DAGCombiner: Pass the correct type to TargetLowering::isF(Abs|Neg)Free · c54731aa
      Tom Stellard authored
      This commit also implements these functions for R600 and removes a test
      case that was relying on the buggy behavior.
      
      llvm-svn: 187007
      c54731aa
Loading