Skip to content
  1. Jun 17, 2008
    • Ted Kremenek's avatar
      This patch is motivated by numerous strict-aliasing warnings when compiling · 08e17118
      Ted Kremenek authored
      clang as a Release build.
      
      The big change is that all AST nodes (subclasses of Stmt) whose children are
      Expr* store their children as Stmt* or arrays of Stmt*. This is to remove
      strict-aliasing warnings when using StmtIterator. None of the interfaces of any
      of the classes have changed (except those with arg_iterators, see below), as the
      accessor methods introduce the needed casts (via cast<>). While this extra
      casting may seem cumbersome, it actually adds some important sanity checks
      throughout the codebase, as clients using StmtIterator can potentially overwrite
      children that are expected to be Expr* with Stmt* (that aren't Expr*). The casts
      provide extra sanity checks that are operational in debug builds to catch
      invariant violations such as these.
      
      For classes that have arg_iterators (e.g., CallExpr), the definition of
      arg_iterator has been replaced. Instead of it being Expr**, it is an actual
      class (called ExprIterator) that wraps a Stmt**, and provides the necessary
      operators for iteration. The nice thing about this class is that it also uses
      cast<> to type-checking, which introduces extra sanity checks throughout the
      codebase that are useful for debugging.
      
      A few of the CodeGen functions that use arg_iterator (especially from
      OverloadExpr) have been modified to take begin and end iterators instead of a
      base Expr** and the number of arguments. This matches more with the abstraction
      of iteration. This still needs to be cleaned up a little bit, as clients expect
      that ExprIterator is a RandomAccessIterator (which we may or may not wish to
      allow for efficiency of representation).
      
      This is a fairly large patch. It passes the tests (except CodeGen/bitfield.c,
      which was already broken) on both a Debug and Release build, but it should
      obviously be reviewed.
      
      llvm-svn: 52378
      08e17118
    • Evan Cheng's avatar
      Rather than avoiding to wrap ISD::DECLARE GV operand in X86ISD::Wrapper,... · e47ca094
      Evan Cheng authored
      Rather than avoiding to wrap ISD::DECLARE GV operand in X86ISD::Wrapper, simply handle it at dagisel time with x86 specific isel code.
      
      llvm-svn: 52377
      e47ca094
    • Ted Kremenek's avatar
      Silence uninitialized value warning in Release build. · 1c77e8f2
      Ted Kremenek authored
      llvm-svn: 52376
      1c77e8f2
    • Ted Kremenek's avatar
      Silence uninitialized value warning during Release build. · bba87243
      Ted Kremenek authored
      llvm-svn: 52375
      bba87243
    • Chris Lattner's avatar
      56cdea6b
    • Evan Cheng's avatar
      Do not issue identity copies. · 1cde1f8d
      Evan Cheng authored
      llvm-svn: 52373
      1cde1f8d
    • Ted Kremenek's avatar
      Remove debugging message in ccc-analyzer. · 51ca6fa5
      Ted Kremenek authored
      Add color diagnostics from scan-build, and indicate the number of bugs found (if any).
      
      llvm-svn: 52372
      51ca6fa5
    • Dan Gohman's avatar
      Refine the change in r52258 for avoiding use-before-def conditions · ab0dccba
      Dan Gohman authored
      when changing the stride of a comparison so that it's slightly
      more precise, by having it scan the instruction list to determine
      if there is a use of the condition after the point where the
      condition will be inserted.
      
      llvm-svn: 52371
      ab0dccba
  2. Jun 16, 2008
Loading