Skip to content
  1. Feb 04, 2011
  2. Feb 03, 2011
  3. Feb 02, 2011
  4. Feb 01, 2011
  5. Jan 31, 2011
  6. Jan 30, 2011
  7. Jan 29, 2011
  8. Jan 28, 2011
  9. Jan 27, 2011
    • Andrew Trick's avatar
    • Andrew Trick's avatar
      VirtRegRewriter fix: update kill flags, which are used by the scavenger. · 13bb644f
      Andrew Trick authored
      rdar://problem/8893967: JM/lencod miscompile at -arch armv7 -mthumb -O3
      
      Added ResurrectKill to remove kill flags after we decide to reused a
      physical register. And (hopefully) ensure that we call it in all the
      right places.
      
      Sorry, I'm not checking in a unit test given that it's a miscompile I
      can't reproduce easily with a toy example. Failures in the rewriter
      depend on a series of heuristic decisions maked during one of the many
      upstream phases in codegen. This case would require coercing regalloc
      to generate a couple of rematerialzations in a way that causes the
      scavenger to reuse the same register at just the wrong point.
      
      The general way to test this is to implement kill flags
      verification. Then we could have a simple, robust compile-only unit
      test. That would be worth doing if the whole pass was not about to
      disappear. At this point we focus verification work on the next
      generation of regalloc.
      
      llvm-svn: 124442
      13bb644f
Loading