Skip to content
  1. Jun 30, 2011
    • Jakob Stoklund Olesen's avatar
      Reapply r134047 now that the world is ready for it. · adc6a4ca
      Jakob Stoklund Olesen authored
      This patch will sometimes choose live range split points next to
      interference instead of always splitting next to a register point. That
      means spill code can now appear almost anywhere, and it was necessary
      to fix code that didn't expect that.
      
      The difficult places were:
      
      - Between a CALL returning a value on the x87 stack and the
        corresponding FpPOP_RETVAL (was FpGET_ST0). Probably also near x87
        inline assembly, but that didn't actually show up in testing.
      
      - Between a CALL popping arguments off the stack and the corresponding
        ADJCALLSTACKUP.
      
      Both are fixed now. The only place spill code can't appear is after
      terminators, see SplitAnalysis::getLastSplitPoint.
      
      Original commit message:
      
      Rewrite RAGreedy::splitAroundRegion, now with cool ASCII art.
      
      This function has to deal with a lot of special cases, and the old
      version got it wrong sometimes. In particular, it would sometimes leave
      multiple uses in the stack interval in a single block. That causes bad
      code with multiple reloads in the same basic block.
      
      The new version handles block entry and exit in a single pass. It first
      eliminates all the easy cases, and then goes on to create a local
      interval for the blocks with difficult interference. Previously, we
      would only create the local interval for completely isolated blocks.
      
      It can happen that the stack interval becomes completely empty because
      we could allocate a register in all edge bundles, and the new local
      intervals deal with the interference. The empty stack interval is
      harmless, but we need to remove a SplitKit assertion that checks for
      empty intervals.
      
      llvm-svn: 134125
      adc6a4ca
  2. Jun 29, 2011
    • Jakob Stoklund Olesen's avatar
      Revert r134047 while investigating a llvm-gcc-i386-linux-selfhost · 8628435c
      Jakob Stoklund Olesen authored
      miscompile.
      
      llvm-svn: 134053
      8628435c
    • Jakob Stoklund Olesen's avatar
      Rewrite RAGreedy::splitAroundRegion, now with cool ASCII art. · ffbc05b7
      Jakob Stoklund Olesen authored
      This function has to deal with a lot of special cases, and the old
      version got it wrong sometimes. In particular, it would sometimes leave
      multiple uses in the stack interval in a single block. That causes bad
      code with multiple reloads in the same basic block.
      
      The new version handles block entry and exit in a single pass. It first
      eliminates all the easy cases, and then goes on to create a local
      interval for the blocks with difficult interference. Previously, we
      would only create the local interval for completely isolated blocks.
      
      It can happen that the stack interval becomes completely empty because
      we could allocate a register in all edge bundles, and the new local
      intervals deal with the interference. The empty stack interval is
      harmless, but we need to remove a SplitKit assertion that checks for
      empty intervals.
      
      llvm-svn: 134047
      ffbc05b7
  3. Jun 27, 2011
  4. Jun 26, 2011
  5. Jun 07, 2011
    • Jakob Stoklund Olesen's avatar
      Simplify local live range splitting's safeguard to fix PR10070. · df476270
      Jakob Stoklund Olesen authored
      When local live range splitting creates a live range with the same
      number of instructions as the old range, mark it as RS_Local. When such
      a range is seen again, require that it be split in a way that reduces
      the number of instructions. That guarantees we are making progress while
      still being able to perform 3 -> 2+3 splits as required by PR10070.
      
      This also means that the PrevSlot map is no longer needed. This was also
      used to estimate new spill weights, but that is no longer necessary
      after slotIndexes::insertMachineInstrInMaps() got the extra Late
      insertion argument.
      
      llvm-svn: 132697
      df476270
  6. Jun 03, 2011
  7. Jun 01, 2011
  8. May 31, 2011
    • Jakob Stoklund Olesen's avatar
      Simplify the eviction policy by making the failsafe explicit. · 73e18b7a
      Jakob Stoklund Olesen authored
      When assigned ranges are evicted, they are put in the RS_Evicted stage and are
      not allowed to evict anything else. That prevents looping automatically.
      
      When evicting ranges just to get a cheaper register, use only spill weights to
      find the possible candidates. Avoid breaking hints for this purpose, it is not
      worth it.
      
      Start implementing more complex eviction heuristics, guarded by the temporary
      -complex-eviction flag. The initial version permits a heavier range to be
      evicted if it doesn't have any uses where the evicting range is live. This makes
      it a good candidate for live ranfge splitting.
      
      llvm-svn: 132358
      73e18b7a
  9. May 30, 2011
  10. May 29, 2011
  11. May 28, 2011
    • Jakob Stoklund Olesen's avatar
      Create two BlockInfo entries when a live range is discontinuous through a block. · fd3f71ef
      Jakob Stoklund Olesen authored
      Delete the Kill and Def markers in BlockInfo. They are no longer
      necessary when BlockInfo describes a continuous live range.
      
      This only affects the relatively rare kind of basic block where a live
      range looks like this:
      
       |---x   o---|
      
      Now live range splitting can pretend that it is looking at two blocks:
      
       |---x
               o---|
      
      This allows the code to be simplified a bit.
      
      llvm-svn: 132245
      fd3f71ef
    • Jakob Stoklund Olesen's avatar
      Add SplitAnalysis::getNumLiveBlocks(). · 5cc91b26
      Jakob Stoklund Olesen authored
      It is important that this function returns the same number of live blocks as
      countLiveBlocks(CurLI) because live range splitting uses the number of live
      blocks to ensure it is making progress.
      
      This is in preparation of supporting duplicate UseBlock entries for basic blocks
      that have a virtual register live-in and live-out, but not live-though.
      
      llvm-svn: 132244
      5cc91b26
  12. May 26, 2011
    • Jakob Stoklund Olesen's avatar
      Add a RAGreedy::canEvict function. · 25d5745c
      Jakob Stoklund Olesen authored
      This doesn't change functionality (much), but it allows for a more fine-grained
      eviction policy. The current policy only compares spill weights, and that is not
      always the best thing to do.  Spill weights are designed to serve linear scan,
      and they don't consider live range splitting.
      
      Add a mechanism so canEvict() can request that a live range be evicted and
      split/spilled. This is to avoid infinite eviction loops.
      
      llvm-svn: 132101
      25d5745c
  13. May 10, 2011
  14. May 06, 2011
  15. May 03, 2011
    • Jakob Stoklund Olesen's avatar
      Gracefully handle invalid live ranges. Fix PR9831. · eaa6ed1a
      Jakob Stoklund Olesen authored
      Register coalescing can sometimes create live ranges that end in the middle of a
      basic block without any killing instruction. When SplitKit detects this, it will
      repair the live range by shrinking it to its uses.
      
      Live range splitting also needs to know about this. When the range shrinks so
      much that it becomes allocatable, live range splitting fails because it can't
      find a good split point. It is paranoid about making progress, so an allocatable
      range is considered an error.
      
      The coalescer should really not be creating these bad live ranges. They appear
      when coalescing dead copies.
      
      llvm-svn: 130787
      eaa6ed1a
  16. Apr 30, 2011
  17. Apr 27, 2011
  18. Apr 23, 2011
  19. Apr 21, 2011
    • Jakob Stoklund Olesen's avatar
      Allow allocatable ranges from global live range splitting to be split again. · 6a663b8d
      Jakob Stoklund Olesen authored
      These intervals are allocatable immediately after splitting, but they may be
      evicted because of later splitting. This is rare, but when it happens they
      should be split again.
      
      The remainder intervals that cannot be allocated after splitting still move
      directly to spilling.
      
      SplitEditor::finish can optionally provide a mapping from new live intervals
      back to the original interval indexes returned by openIntv().
      
      Each original interval index can map to multiple new intervals after connected
      components have been separated. Dead code elimination may also add existing
      intervals to the list.
      
      The reverse mapping allows the SplitEditor client to treat the new intervals
      differently depending on the split region they came from.
      
      llvm-svn: 129925
      6a663b8d
  20. Apr 20, 2011
    • Jakob Stoklund Olesen's avatar
      Prefer cheap registers for busy live ranges. · 0e34c1df
      Jakob Stoklund Olesen authored
      On the x86-64 and thumb2 targets, some registers are more expensive to encode
      than others in the same register class.
      
      Add a CostPerUse field to the TableGen register description, and make it
      available from TRI->getCostPerUse. This represents the cost of a REX prefix or a
      32-bit instruction encoding required by choosing a high register.
      
      Teach the greedy register allocator to prefer cheap registers for busy live
      ranges (as indicated by spill weight).
      
      llvm-svn: 129864
      0e34c1df
  21. Apr 13, 2011
  22. Apr 12, 2011
  23. Apr 11, 2011
  24. Apr 09, 2011
  25. Apr 07, 2011
  26. Apr 06, 2011
  27. Apr 05, 2011
  28. Apr 04, 2011
  29. Apr 02, 2011
Loading