Skip to content
  1. Oct 02, 2012
  2. Oct 01, 2012
    • Micah Villmow's avatar
    • Benjamin Kramer's avatar
      Provide a shortcut for MCObjectStreamer when emitting fills. · 4c8af550
      Benjamin Kramer authored
      Reduces runtime of i386-large-relocations.s by 10x in Release builds, even more
      in Debug+Asserts builds.
      
      llvm-svn: 164945
      4c8af550
    • Chandler Carruth's avatar
      Make this plural. Spotted by Duncan in review (and a very old typo, this · d71ef3a0
      Chandler Carruth authored
      is the second time I've moved this comment around...)
      
      llvm-svn: 164939
      d71ef3a0
    • Chandler Carruth's avatar
      Prune some unnecessary includes. · d325f802
      Chandler Carruth authored
      llvm-svn: 164938
      d325f802
    • Chandler Carruth's avatar
      Fix several issues with alignment. We weren't always accounting for type · 176ca71a
      Chandler Carruth authored
      alignment requirements of the new alloca. As one consequence which was
      reported as a bug by Duncan, we overaligned memcpy calls to ranges of
      allocas after they were rewritten to types with lower alignment
      requirements. Other consquences are possible, but I don't have any test
      cases for them.
      
      llvm-svn: 164937
      176ca71a
    • Benjamin Kramer's avatar
      SimplifyCFG: Don't crash when forming a switch bitmap with an undef default value. · 9fc3dc77
      Benjamin Kramer authored
      Fixes PR13985.
      
      llvm-svn: 164934
      9fc3dc77
    • Chandler Carruth's avatar
      Factor the PHI and select speculation into a separate rewriter. This · 82a57543
      Chandler Carruth authored
      could probably be factored still further to hoist this logic into
      a generic helper, but currently I don't have particularly clean ideas
      about how to handle that.
      
      This at least allows us to drop custom load rewriting from the
      speculation logic, which in turn allows the existing load rewriting
      logic to fire. In theory, this could enable vector promotion or other
      tricks after speculation occurs, but I've not dug into such issues. This
      is primarily just cleaning up the factoring of the code and the
      resulting logic.
      
      llvm-svn: 164933
      82a57543
    • Craig Topper's avatar
    • Chandler Carruth's avatar
      Refactor the PartitionUse structure to actually use the Use* instead of · 54e8f0b4
      Chandler Carruth authored
      a pair of instructions, one for the used pointer and the second for the
      user. This simplifies the representation and also makes it more dense.
      
      This was noticed because of the miscompile in PR13926. In that case, we
      were running up against a fundamental "bad idea" in the speculation of
      PHI and select instructions: the speculation and rewriting are
      interleaved, which requires phi speculation to also perform load
      rewriting! This is bad, and causes us to miss opportunities to do (for
      example) vector rewriting only exposed after PHI speculation, etc etc.
      It also, in the old system, required us to insert *new* load uses into
      the current partition's use list, which would then be ignored during
      rewriting because we had already extracted an end iterator for the use
      list. The appending behavior (and much of the other oddities) stem from
      the strange de-duplication strategy in the PartitionUse builder.
      Amusingly, all this went without notice for so long because it could
      only be triggered by having *different* GEPs into the same partition of
      the same alloca, where both different GEPs were operands of a single
      PHI, and where the GEP which was not encountered first also had multiple
      uses within that same PHI node... Hence the insane steps required to
      reproduce.
      
      So, step one in fixing this fundamental bad idea is to make the
      PartitionUse actually contain a Use*, and to make the builder do proper
      deduplication instead of funky de-duplication. This is enough to remove
      the appending behavior, and fix the miscompile in PR13926, but there is
      more work to be done here. Subsequent commits will lift the speculation
      into its own visitor. It'll be a useful step toward potentially
      extracting all of the speculation logic into a generic utility
      transform.
      
      The existing PHI test case for repeated operands has been made more
      extreme to catch even these issues. This test case, run through the old
      pass, will exactly reproduce the miscompile from PR13926. ;] We were so
      close here!
      
      llvm-svn: 164925
      54e8f0b4
  3. Sep 30, 2012
  4. Sep 29, 2012
  5. Sep 28, 2012
Loading