- Mar 31, 2012
-
-
Hal Finkel authored
Dynamic linking on PPC64 has had problems since we had to move the top-down hazard-detection logic post-ra. For dynamic linking to work there needs to be a nop placed after every call. It turns out that it is really hard to guarantee that nothing will be placed in between the call (bl) and the nop during post-ra scheduling. Previous attempts at fixing this by placing logic inside the hazard detector only partially worked. This is now fixed in a different way: call+nop codegen-only instructions. As far as CodeGen is concerned the pair is now a single instruction and cannot be split. This solution works much better than previous attempts. The scoreboard hazard detector is also renamed to be more generic, there is currently no cpu-specific logic in it. llvm-svn: 153816
-
Chandler Carruth authored
llvm-svn: 153815
-
Chandler Carruth authored
the very high overhead of the complex inline cost analysis when all it wants to do is detect three patterns which must not be inlined. Comment the code, clean it up, and leave some hints about possible performance improvements if this ever shows up on a profile. Moving this off of the (now more expensive) inline cost analysis is particularly important because we have to run this inliner even at -O0. llvm-svn: 153814
-
Chandler Carruth authored
interfaces. These methods were used in the old inline cost system where there was a persistent cache that had to be updated, invalidated, and cleared. We're now doing more direct computations that don't require this intricate dance. Even if we resume some level of caching, it would almost certainly have a simpler and more narrow interface than this. llvm-svn: 153813
-
Chandler Carruth authored
on a per-callsite walk of the called function's instructions, in breadth-first order over the potentially reachable set of basic blocks. This is a major shift in how inline cost analysis works to improve the accuracy and rationality of inlining decisions. A brief outline of the algorithm this moves to: - Build a simplification mapping based on the callsite arguments to the function arguments. - Push the entry block onto a worklist of potentially-live basic blocks. - Pop the first block off of the *front* of the worklist (for breadth-first ordering) and walk its instructions using a custom InstVisitor. - For each instruction's operands, re-map them based on the simplification mappings available for the given callsite. - Compute any simplification possible of the instruction after re-mapping, and store that back int othe simplification mapping. - Compute any bonuses, costs, or other impacts of the instruction on the cost metric. - When the terminator is reached, replace any conditional value in the terminator with any simplifications from the mapping we have, and add any successors which are not proven to be dead from these simplifications to the worklist. - Pop the next block off of the front of the worklist, and repeat. - As soon as the cost of inlining exceeds the threshold for the callsite, stop analyzing the function in order to bound cost. The primary goal of this algorithm is to perfectly handle dead code paths. We do not want any code in trivially dead code paths to impact inlining decisions. The previous metric was *extremely* flawed here, and would always subtract the average cost of two successors of a conditional branch when it was proven to become an unconditional branch at the callsite. There was no handling of wildly different costs between the two successors, which would cause inlining when the path actually taken was too large, and no inlining when the path actually taken was trivially simple. There was also no handling of the code *path*, only the immediate successors. These problems vanish completely now. See the added regression tests for the shiny new features -- we skip recursive function calls, SROA-killing instructions, and high cost complex CFG structures when dead at the callsite being analyzed. Switching to this algorithm required refactoring the inline cost interface to accept the actual threshold rather than simply returning a single cost. The resulting interface is pretty bad, and I'm planning to do lots of interface cleanup after this patch. Several other refactorings fell out of this, but I've tried to minimize them for this patch. =/ There is still more cleanup that can be done here. Please point out anything that you see in review. I've worked really hard to try to mirror at least the spirit of all of the previous heuristics in the new model. It's not clear that they are all correct any more, but I wanted to minimize the change in this single patch, it's already a bit ridiculous. One heuristic that is *not* yet mirrored is to allow inlining of functions with a dynamic alloca *if* the caller has a dynamic alloca. I will add this back, but I think the most reasonable way requires changes to the inliner itself rather than just the cost metric, and so I've deferred this for a subsequent patch. The test case is XFAIL-ed until then. As mentioned in the review mail, this seems to make Clang run about 1% to 2% faster in -O0, but makes its binary size grow by just under 4%. I've looked into the 4% growth, and it can be fixed, but requires changes to other parts of the inliner. llvm-svn: 153812
-
Chandler Carruth authored
visitor will now visit a CallInst and an InvokeInst with instruction-specific visitors, then visit a generic CallSite visitor, then delegate back to the Instruction visitor and the TerminatorInst visitors depending on whether a call or an invoke originally. This will be used in the soon-to-land inline cost rewrite. llvm-svn: 153811
-
Bill Wendling authored
llvm-svn: 153810
-
Bill Wendling authored
llvm-svn: 153809
-
Bill Wendling authored
llvm-svn: 153808
-
Bill Wendling authored
llvm-svn: 153807
-
Benjamin Kramer authored
Internalize: Remove reference of @llvm.noinline, it was replaced with the noinline attribute a long time ago. llvm-svn: 153806
-
Bill Wendling authored
llvm-svn: 153805
-
Bill Wendling authored
llvm-svn: 153804
-
Bill Wendling authored
llvm-svn: 153803
-
Bill Wendling authored
llvm-svn: 153802
-
Chandler Carruth authored
one point, and I forgot to go back and clean it up. Sorry about that. =/ llvm-svn: 153801
-
Benjamin Kramer authored
llvm-svn: 153800
-
Chandler Carruth authored
things around. llvm-svn: 153799
-
Duncan Sands authored
node and returning it if one didn't exist. llvm-svn: 153798
-
Hal Finkel authored
The powi intrinsic requires special handling because it always takes a single integer power regardless of the result type. As a result, we can vectorize only if the powers are equal. Fixes PR12364. llvm-svn: 153797
-
Andrew Trick authored
llvm-svn: 153796
-
Akira Hatanaka authored
llvm-svn: 153795
-
Andrew Trick authored
First small step toward modeling multi-register multi-pressure. In the future, register units can also be used to model liveness and aliasing. llvm-svn: 153794
-
Argyrios Kyrtzidis authored
to do a nil check for the result of the call. rdar://10950973 llvm-svn: 153793
-
Argyrios Kyrtzidis authored
When indexing a property with a getter/setter with attributes, the allocated memory for AttrListInfo could get released before its destructor is run. Fixes rdar://11113442. llvm-svn: 153792
-
Enrico Granata authored
Making sure the count on synthetic providers is always setup - This should prevent errors about count being undefined from showing up llvm-svn: 153791
-
Greg Clayton authored
llvm-svn: 153790
-
Jakob Stoklund Olesen authored
ARMConstantIslandPass still has bugs where jump table compression can cause constant pool entries to go out of range. Add a safety margin of 2 bytes when placing constant islands, but use the real max displacement for verification. <rdar://problem/11156595> llvm-svn: 153789
-
Jakob Stoklund Olesen authored
llvm-svn: 153788
-
Greg Clayton authored
(lldb) log enable --verbose lldb completion This will print out backtraces for all type completion calls which will help us verify that we don't ever complete a type when we don't need to. llvm-svn: 153787
-
Greg Clayton authored
llvm-svn: 153786
-
Greg Clayton authored
llvm-svn: 153785
-
Fariborz Jahanian authored
literals. wip. // rdar://10803676 llvm-svn: 153784
-
Bill Wendling authored
into the function. * Reorder some header files. llvm-svn: 153783
-
Benjamin Kramer authored
It's slow, bloated and completely redundant with MCRegisterClass::contains. llvm-svn: 153782
-
Argyrios Kyrtzidis authored
After getting a cursor with clang_getCursor for a particular source location, allows querying the cursor in order to find out if the location points to a selector identifier in an objc method or message expression, and which selector index it is. rdar://11158946 llvm-svn: 153781
-
- Mar 30, 2012
-
-
Jim Grosbach authored
The 8-bit payload is not contiguous in the opcode. Move the upper nibble over 4 bits into the correct place. rdar://11158641 llvm-svn: 153780
-
Benjamin Kramer authored
- Add memcpy and memcmp to the stub headers. - __uint128_t is not available on 32 bit platforms. It's also unused so just comment it out for now. llvm-svn: 153779
-
John McCall authored
in the fragile and non-fragile Mac ObjC runtimes. No useful test case. Fixes rdar://problem/11072576. llvm-svn: 153778
-
Jakob Stoklund Olesen authored
This allows suffix sharing in register names. (AX is a suffix of EAX). llvm-svn: 153777
-