Skip to content
  1. May 01, 2012
  2. Apr 29, 2012
  3. Apr 28, 2012
  4. Apr 26, 2012
    • Andrew Trick's avatar
      Fix the SD scheduler to avoid gluing the same node twice. · 03fa574a
      Andrew Trick authored
      DAGCombine strangeness may result in multiple loads from the same
      offset. They both may try to glue themselves to another load. We could
      insist that the redundant loads glue themselves to each other, but the
      beter fix is to bail out from bad gluing at the time we detect it.
      
      Fixes rdar://11314175: BuildSchedUnits assert.
      
      llvm-svn: 155668
      03fa574a
  5. Apr 25, 2012
  6. Apr 24, 2012
  7. Apr 23, 2012
    • Preston Gurd's avatar
      This patch fixes a problem which arose when using the Post-RA scheduler · 9a091475
      Preston Gurd authored
      on X86 Atom. Some of our tests failed because the tail merging part of
      the BranchFolding pass was creating new basic blocks which did not
      contain live-in information. When the anti-dependency code in the Post-RA
      scheduler ran, it would sometimes rename the register containing
      the function return value because the fact that the return value was
      live-in to the subsequent block had been lost. To fix this, it is necessary
      to run the RegisterScavenging code in the BranchFolding pass.
      
      This patch makes sure that the register scavenging code is invoked
      in the X86 subtarget only when post-RA scheduling is being done.
      Post RA scheduling in the X86 subtarget is only done for Atom.
      
      This patch adds a new function to the TargetRegisterClass to control
      whether or not live-ins should be preserved during branch folding.
      This is necessary in order for the anti-dependency optimizations done
      during the PostRASchedulerList pass to work properly when doing
      Post-RA scheduling for the X86 in general and for the Intel Atom in particular.
      
      The patch adds and invokes the new function trackLivenessAfterRegAlloc()
      instead of using the existing requiresRegisterScavenging().
      It changes BranchFolding.cpp to call trackLivenessAfterRegAlloc() instead of
      requiresRegisterScavenging(). It changes the all the targets that
      implemented requiresRegisterScavenging() to also implement
      trackLivenessAfterRegAlloc().  
      
      It adds an assertion in the Post RA scheduler to make sure that post RA
      liveness information is available when it is needed.
      
      It changes the X86 break-anti-dependencies test to use –mcpu=atom, in order
      to avoid running into the added assertion.
      
      Finally, this patch restores the use of anti-dependency checking
      (which was turned off temporarily for the 3.1 release) for
      Intel Atom in the Post RA scheduler.
      
      Patch by Andy Zhang!
      
      Thanks to Jakob and Anton for their reviews.
      
      llvm-svn: 155395
      9a091475
    • Chandler Carruth's avatar
      Temporarily revert r155364 until the upstream review can complete, per · af0f8bf5
      Chandler Carruth authored
      the stated developer policy.
      
      llvm-svn: 155373
      af0f8bf5
    • Sirish Pande's avatar
      Hexagon Packetizer's target independent fix. · 995c8dbf
      Sirish Pande authored
      llvm-svn: 155364
      995c8dbf
  8. Apr 22, 2012
  9. Apr 21, 2012
    • Nadav Rotem's avatar
    • Jakob Stoklund Olesen's avatar
      Fix PR12599. · d114da60
      Jakob Stoklund Olesen authored
      The X86 target is editing the selection DAG while isel is selecting
      nodes following a topological ordering. When the DAG hacking triggers
      CSE, nodes can be deleted and bad things happen.
      
      llvm-svn: 155257
      d114da60
    • Jakob Stoklund Olesen's avatar
      Make ISelPosition a local variable. · e3a891cf
      Jakob Stoklund Olesen authored
      Now that multiple DAGUpdateListeners can be active at the same time,
      ISelPosition can become a local variable in DoInstructionSelection.
      
      We simply register an ISelUpdater with CurDAG while ISelPosition exists.
      
      llvm-svn: 155249
      e3a891cf
    • Jakob Stoklund Olesen's avatar
      Register DAGUpdateListeners with SelectionDAG. · beb9469d
      Jakob Stoklund Olesen authored
      Instead of passing listener pointers to RAUW, let SelectionDAG itself
      keep a linked list of interested listeners.
      
      This makes it possible to have multiple listeners active at once, like
      RAUWUpdateListener was already doing. It also makes it possible to
      register listeners up the call stack without controlling all RAUW calls
      below.
      
      DAGUpdateListener uses an RAII pattern to add itself to the SelectionDAG
      list of active listeners.
      
      llvm-svn: 155248
      beb9469d
  10. Apr 20, 2012
    • Jakob Stoklund Olesen's avatar
      Print <def,read-undef> to avoid confusion. · 7111a630
      Jakob Stoklund Olesen authored
      The <undef> flag on a def operand only applies to partial register
      redefinitions. Only print the flag when relevant, and print it as
      <def,read-undef> to make it clearer what it means.
      
      llvm-svn: 155239
      7111a630
    • Andrew Trick's avatar
      New and improved comment. · 51ee9361
      Andrew Trick authored
      llvm-svn: 155229
      51ee9361
    • Andrew Trick's avatar
      SparseSet: Add support for key-derived indexes and arbitrary key types. · 1eb4a0da
      Andrew Trick authored
      This nicely handles the most common case of virtual register sets, but
      also handles anticipated cases where we will map pointers to IDs.
      
      The goal is not to develop a completely generic SparseSet
      template. Instead we want to handle the expected uses within llvm
      without any template antics in the client code. I'm adding a bit of
      template nastiness here, and some assumption about expected usage in
      order to make the client code very clean.
      
      The expected common uses cases I'm designing for:
      - integer keys that need to be reindexed, and may map to additional
        data
      - densely numbered objects where we want pointer keys because no
        number->object map exists.
      
      llvm-svn: 155227
      1eb4a0da
    • Andrew Trick's avatar
      misched: initialize BB · 7405c6d5
      Andrew Trick authored
      llvm-svn: 155226
      7405c6d5
  11. Apr 19, 2012
  12. Apr 18, 2012
    • Chandler Carruth's avatar
      This reverts a long string of commits to the Hexagon backend. These · b415bf98
      Chandler Carruth authored
      commits have had several major issues pointed out in review, and those
      issues are not being addressed in a timely fashion. Furthermore, this
      was all committed leading up to the v3.1 branch, and we don't need piles
      of code with outstanding issues in the branch.
      
      It is possible that not all of these commits were necessary to revert to
      get us back to a green state, but I'm going to let the Hexagon
      maintainer sort that out. They can recommit, in order, after addressing
      the feedback.
      
      Reverted commits, with some notes:
      
      Primary commit r154616: HexagonPacketizer
        - There are lots of review comments here. This is the primary reason
          for reverting. In particular, it introduced large amount of warnings
          due to a bad construct in tablegen.
        - Follow-up commits that should be folded back into this when
          reposting:
          - r154622: CMake fixes
          - r154660: Fix numerous build warnings in release builds.
        - Please don't resubmit this until the three commits above are
          included, and the issues in review addressed.
      
      Primary commit r154695: Pass to replace transfer/copy ...
        - Reverted to minimize merge conflicts. I'm not aware of specific
          issues with this patch.
      
      Primary commit r154703: New Value Jump.
        - Primarily reverted due to merge conflicts.
        - Follow-up commits that should be folded back into this when
          reposting:
          - r154703: Remove iostream usage
          - r154758: Fix CMake builds
          - r154759: Fix build warnings in release builds
        - Please incorporate these fixes and and review feedback before
          resubmitting.
      
      Primary commit r154829: Hexagon V5 (floating point) support.
        - Primarily reverted due to merge conflicts.
        - Follow-up commits that should be folded back into this when
          reposting:
          - r154841: Remove unused variable (fixing build warnings)
      
      There are also accompanying Clang commits that will be reverted for
      consistency.
      
      llvm-svn: 155047
      b415bf98
    • Pete Cooper's avatar
      LiveIntervalUpdate validators weren't recorded after the calls to... · 8998657c
      Pete Cooper authored
      LiveIntervalUpdate validators weren't recorded after the calls to std::for_each.  Turns out std::for_each doesn't update the variable passed in for the functor but instead copy constructs a new one.
      
      llvm-svn: 155041
      8998657c
    • Joel Jones's avatar
      Fixes a problem in instruction selection with testing whether or not the · 828531f7
      Joel Jones authored
      transformation:
      
      (X op C1) ^ C2 --> (X op C1) & ~C2 iff (C1&C2) == C2
      
      should be done.  
      
      This change has been tested:
       Using a debug+asserts build:
         on the specific test case that brought this bug to light
         make check-all
         lnt nt
         using this clang to build a release version of clang
       Using the release+asserts clang-with-clang build:
         on the specific test case that brought this bug to light
         make check-all
         lnt nt
      
      Checking in because Evan wants it checked in.  Test case forthcoming after
      scrubbing.
      
      llvm-svn: 154955
      828531f7
  13. Apr 17, 2012
    • Lang Hames's avatar
      SlotIndexes used to store the index list in a crufty custom linked-list. I can't · aef91783
      Lang Hames authored
      for the life of me remember why I wrote it this way, but I can't see any good
      reason for it now. This patch replaces the custom linked list with an ilist.
      
      This change should preserve the existing numberings exactly, so no generated code
      should change (if it does, file a bug!).
      
      llvm-svn: 154904
      aef91783
    • Eric Christopher's avatar
      Make comment here more clear. · a8caa739
      Eric Christopher authored
      llvm-svn: 154878
      a8caa739
    • Chandler Carruth's avatar
      Fix updateTerminator to be resiliant to degenerate terminators where · 1f5580b6
      Chandler Carruth authored
      both fallthrough and a conditional branch target the same successor.
      Gracefully delete the conditional branch and introduce any unconditional
      branch needed to reach the actual successor. This fixes memory
      corruption in 2009-06-15-RegScavengerAssert.ll and possibly other tests.
      
      Also, while I'm here fix a latent bug I spotted by inspection. I never
      applied the same fundamental fix to this fallthrough successor finding
      logic that I did to the logic used when there are no conditional
      branches. As a consequence it would have selected landing pads had they
      be aligned in just the right way here. I don't have a test case as
      I spotted this by inspection, and the previous time I found this
      required have of TableGen's source code to produce it. =/ I hate backend
      bugs. ;]
      
      Thanks to Jim Grosbach for helping me reason through this and reviewing
      the fix.
      
      llvm-svn: 154867
      1f5580b6
Loading