Skip to content
  1. May 22, 2009
    • Duncan Sands's avatar
      Add a new codegen pass that normalizes dwarf exception handling · d6fb6501
      Duncan Sands authored
      code in preparation for code generation.  The main thing it does
      is handle the case when eh.exception calls (and, in a future
      patch, eh.selector calls) are far away from landing pads.  Right
      now in practice you only find eh.exception calls close to landing
      pads: either in a landing pad (the common case) or in a landing
      pad successor, due to loop passes shifting them about.  However
      future exception handling improvements will result in calls far
      from landing pads:
      (1) Inlining of rewinds.  Consider the following case:
      In function @f:
      ...
        invoke @g to label %normal unwind label %unwinds
      ...
      unwinds:
        %ex = call i8* @llvm.eh.exception()
      ...
      
      In function @g:
      ...
        invoke @something to label %continue unwind label %handler
      ...
      handler:
        %ex = call i8* @llvm.eh.exception()
      ... perform cleanups ...
        "rethrow exception"
      
      Now inline @g into @f.  Currently this is turned into:
      In function @f:
      ...
        invoke @something to label %continue unwind label %handler
      ...
      handler:
        %ex = call i8* @llvm.eh.exception()
      ... perform cleanups ...
        invoke "rethrow exception" to label %normal unwind label %unwinds
      unwinds:
        %ex = call i8* @llvm.eh.exception()
      ...
      
      However we would like to simplify invoke of "rethrow exception" into
      a branch to the %unwinds label.  Then %unwinds is no longer a landing
      pad, and the eh.exception call there is then far away from any landing
      pads.
      
      (2) Using the unwind instruction for cleanups.
      It would be nice to have codegen handle the following case:
        invoke @something to label %continue unwind label %run_cleanups
      ...
      handler:
      ... perform cleanups ...
        unwind
      
      This requires turning "unwind" into a library call, which
      necessarily takes a pointer to the exception as an argument
      (this patch also does this unwind lowering).  But that means
      you are using eh.exception again far from a landing pad.
      
      (3) Bugpoint simplifications.  When bugpoint is simplifying
      exception handling code it often generates eh.exception calls
      far from a landing pad, which then causes codegen to assert.
      Bugpoint then latches on to this assertion and loses sight
      of the original problem.
      
      Note that it is currently rare for this pass to actually do
      anything.  And in fact it normally shouldn't do anything at
      all given the code coming out of llvm-gcc!  But it does fire
      a few times in the testsuite.  As far as I can see this is
      almost always due to the LoopStrengthReduce codegen pass
      introducing pointless loop preheader blocks which are landing
      pads and only contain a branch to another block.  This other
      block contains an eh.exception call.  So probably by tweaking
      LoopStrengthReduce a bit this can be avoided.
      
      llvm-svn: 72276
      d6fb6501
    • Bob Wilson's avatar
      Only 64-bit targets support TImode libcalls. Disable the TImode shift libcalls · ccbc17b3
      Bob Wilson authored
      for ARM.  This fixes rdar://6908807.
      
      llvm-svn: 72269
      ccbc17b3
    • Dan Gohman's avatar
      Teach IndVarSimplify's FixUsesBeforeDefs to handle InvokeInsts by · 781b75a7
      Dan Gohman authored
      assuming that the use of the value is in a block dominated by the
      "normal" destination. LangRef.html and other documentation sources
      don't explicitly guarantee this, but it seems to be assumed in
      other places in LLVM at least.
      
      This fixes an assertion failure on the included testcase, which
      is derived from the Ada testsuite.
      
      FixUsesBeforeDefs is a temporary measure which I'm looking to
      replace with a more capable solution.
      
      llvm-svn: 72266
      781b75a7
    • Sanjiv Gupta's avatar
      Emit debug information for globals (which include automatic variables as well... · 43becc23
      Sanjiv Gupta authored
      Emit debug information for globals (which include automatic variables as well because on PIC16 they are emitted as globals by the frontend).
      
      llvm-svn: 72262
      43becc23
    • Duncan Sands's avatar
      Hopefully fix the build for people with ocaml. · dfc2e571
      Duncan Sands authored
      llvm-svn: 72254
      dfc2e571
    • Duncan Sands's avatar
      Always verify dominfo if expensive checking is enabled. · e5e9f09c
      Duncan Sands authored
      llvm-svn: 72253
      e5e9f09c
    • Dan Gohman's avatar
      Fix a thinko in the code that adapted SCEVMulExpr operands for · 88e06db1
      Dan Gohman authored
      use in expanding SCEVAddExprs with GEPs. The operands of a
      SCEVMulExpr need to be multiplied together, not added.
      
      llvm-svn: 72250
      88e06db1
    • Torok Edwin's avatar
      Revert this. There's no way to verifiy indirect calls, and an optimizer can turn · 9c4dcfb4
      Torok Edwin authored
      indirect call into direct call, thus the verifier would reject something it
      previously accepted.
      
      llvm-svn: 72249
      9c4dcfb4
    • Torok Edwin's avatar
      Verify that calling conventions match function prototype. · a39d6968
      Torok Edwin authored
      This only rejects mismatches between target specific calling convention
      and C/LLVM specific calling convention.
      There are too many fastcc/C, coldcc/cc42 mismatches in the testsuite, these are
      not reject by the verifier.
      
      llvm-svn: 72248
      a39d6968
    • Eli Friedman's avatar
      Fix loop-index-split to correctly preserve dominance frontiers. Part of · 0cf811df
      Eli Friedman authored
      PR4238.
      
      llvm-svn: 72244
      0cf811df
    • Daniel Dunbar's avatar
      Add llvm::triple constructor from arch, vendor, os strings, and recognize · e3384c4f
      Daniel Dunbar authored
      DragonFly OS type.
      
      llvm-svn: 72242
      e3384c4f
    • Dan Gohman's avatar
      Update an assertion string to new-style type names. · faa7d055
      Dan Gohman authored
      llvm-svn: 72239
      faa7d055
    • Evan Cheng's avatar
      80 column violation. · db338f3f
      Evan Cheng authored
      llvm-svn: 72235
      db338f3f
    • Dale Johannesen's avatar
      TableGen for fast isel seems to assume an 'imm' · 4ff70e38
      Dale Johannesen authored
      operand is the last in a pattern.  There is no
      reason this should be true (although apparently
      it always is right now).
      
      llvm-svn: 72232
      4ff70e38
  2. May 21, 2009
  3. May 20, 2009
Loading